Conversation
Jonathanlyj
reviewed
Apr 5, 2025
Collaborator
There was a problem hiding this comment.
This should fix the OpenMPI compatibility issue. mpi4py.MPI are Python-level objects that safely wrap the underlying MPI_Datatype, regardless of whether it is an integer (as in MPICH) or a pointer (as in OpenMPI).
Jonathanlyj
reviewed
Apr 5, 2025
| numpy.import_array() | ||
|
|
||
|
|
||
| ctypedef MPI.Datatype Datatype |
Collaborator
There was a problem hiding this comment.
Is this change necessary to fix the OpenMPI issue? this should just create an alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We tested PnetCDF-Python using MPICH only.
This PR adds support for using OpenMPI.
Note some data objects defined in mpich are different between MPICH and OpenMPI.
For example, MPI_CHAR is a C constant in MPICH and enurm in OpenMPI.
MPI_Comm is an int in MPICH and struct pointer in OpenMPI.