Draft
Conversation
Member
|
Just a question: What is the usage of this? I have no problem with adding it, but I want to know why we have this module. |
Contributor
Author
|
#12 |
98b2a73 to
be43dbf
Compare
be43dbf to
9dd253d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO Jackson Implementation.
Based off #15 for the
AdapterPresenceTestTODO:
FeatherModule.VERSIONJacksonTestignoreNonDocumentedimplementationThings noticed:
Parameter indexes cannot be stored safely asParameterDatauses a signed byte for the index, should really be unsigned (0-255)bytes #10IllegalArgumentExceptionused in places instead ofJsonParseException/JsonDataExceptionCloses #12