Add unpick mappings to parchment#320
Draft
Earthcomputer wants to merge 3 commits intoParchmentMC:versions/1.21.xfrom
Draft
Add unpick mappings to parchment#320Earthcomputer wants to merge 3 commits intoParchmentMC:versions/1.21.xfrom
Earthcomputer wants to merge 3 commits intoParchmentMC:versions/1.21.xfrom
Conversation
Author
|
Converting to a draft as Fabric is discussing some changes to the json format |
Member
|
@Earthcomputer How is this coming along? |
|
is this gonna be reviewed anytime soon? |
Author
|
It can't be reviewed as it is a draft. It now needs updating for unpick v3 |
Member
|
Any updates on this? |
modmuss50
reviewed
Oct 26, 2025
Comment on lines
+1
to
+5
| { | ||
| "version": 1, | ||
| "unpickGroup": "net.fabricmc.unpick", | ||
| "unpickVersion": "${version}" | ||
| } |
There was a problem hiding this comment.
Parchment shouldnt have this file, its purely a yarn + loom thing and wasnt designed to be used by other "none yarn like" mappings. Especially with the V2 spec of this file. Loom will need some changes to handle reading unpick from parchment anyway,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To start with (because it requires at least some mappings to work) I've added
set_block_flags, mostly copied and remapped from yarn (hopefully they'll be fine with that).Unpick mappings are exported to the
extras/definitions.unpickfile in the parchment export zips.