Add manual backup creation and delete buttons to Update Manager#1255
Open
Sebbeben wants to merge 5 commits intoPart-DB:masterfrom
Open
Add manual backup creation and delete buttons to Update Manager#1255Sebbeben wants to merge 5 commits intoPart-DB:masterfrom
Sebbeben wants to merge 5 commits intoPart-DB:masterfrom
Conversation
- Add "Create Backup" button in the backups tab for on-demand backups - Add delete buttons (trash icons) for update logs and backups - New controller routes with CSRF protection and permission checks - Use data-turbo-confirm for CSP-safe confirmation dialogs - Add deleteLog() method to UpdateExecutor with filename validation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
============================================
+ Coverage 54.77% 55.30% +0.52%
- Complexity 8012 8030 +18
============================================
Files 601 601
Lines 25690 25745 +55
============================================
+ Hits 14072 14237 +165
+ Misses 11618 11508 -110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ple from auto-update - Decouple backup creation/restore UI from can_auto_update so Docker and other non-git installations can use backup features - Add backup download endpoint for saving backups externally - Fix SQLite restore to use configured DATABASE_URL path instead of hardcoded var/app.db (affects Docker and custom SQLite paths) - Show Docker-specific warning about var/backups/ not being persisted - Pass is_docker flag to template via InstallationTypeDetector
- Controller tests: auth, CSRF validation, 404 for missing backups, restore disabled check - UpdateExecutor: deleteLog validation, non-existent file, successful deletion - BackupManager: deleteBackup validation for missing/non-zip files
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds backup management buttons to the Update Manager and improves Docker support:
var/backups/is not a persistent volumevar/backups/DATABASE_URLpath instead of hardcodedvar/app.db(fixes restore for Docker's defaultuploads/app.dband any custom SQLite path)@system.manage_updatespermission checksdata-turbo-confirmfor CSP-safe confirmation dialogs (no inline JS)Changes
UpdateManagerController.phpInstallationTypeDetector, download endpoint, passis_dockerto templateBackupManager.phpindex.html.twigcan_auto_update, added download button, Docker warningmessages.en.xlfTesting done
@system.manage_updatespermission