This repository was archived by the owner on Feb 4, 2019. It is now read-only.
Don't check system drive info for *nix default drive#427
Open
sburnicki wants to merge 1 commit intoPash-Project:masterfrom
Open
Don't check system drive info for *nix default drive#427sburnicki wants to merge 1 commit intoPash-Project:masterfrom
sburnicki wants to merge 1 commit intoPash-Project:masterfrom
Conversation
Contributor
|
Build has been run successfully on Appveyor: https://ci.appveyor.com/project/JayBazuzi/pash/build/0.0.224 It has been run even for the previous PR: https://ci.appveyor.com/project/JayBazuzi/pash/build/0.0.223 @JayBazuzi, it seems that something's wrong with our Appveyor settings, because it's unable to report build results back to GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new submit of #426 which will hopefully trigger the checks.
This fixes #425 as discussed and tested on the mailing list.
For non-Windows systems we provide a special "File" drive for the root folder.
It does not make sense to check System.IO.DriveInfo information for this drive,
as it is always valid on *nix systems.
When running Pash in docker, this can actually cause Pash to be unusable since "/" might not be listed as a mounted filesystem, so mono can't provide information about it.