SAF-210 - Fix debug build error with apache commons-io lib#775
Merged
SAF-210 - Fix debug build error with apache commons-io lib#775
Conversation
tstirrat
suggested changes
May 7, 2020
Contributor
tstirrat
left a comment
tstirrat
left a comment
There was a problem hiding this comment.
Thanks for this. Hopefully there's a way to make the patch cleaner and isolated from the other.
tstirrat
changed the title
tstirrat
previously approved these changes
May 9, 2020
Contributor
tstirrat
left a comment
tstirrat
left a comment
There was a problem hiding this comment.
I reverted yarn.lock because I don't think that is necessary and all those updates to individual deps should be isolated.
tstirrat
approved these changes
May 9, 2020
Contributor
tstirrat
left a comment
tstirrat
left a comment
There was a problem hiding this comment.
Tested the apk and it works! no red error
aputinski
pushed a commit
to safe-paths-contrib/covid-safe-paths
that referenced
this pull request
May 11, 2020
* official/develop: Fix EULA modal close icon color (Path-Check#792) feat(i18n) Language updates, May 10 (Path-Check#790) feat(GPS) Store Location Data in an encrypted Realm DB (Path-Check#788) Enable location status checks in testing build (Path-Check#787) fix(Onboarding) Fix EULA links to open in device browser (Path-Check#783) chore(Build) Fix debug build error with apache commons-io lib (Path-Check#775, SAF-210) chore(Testing) snapshot tests for LocationTracking, main/* (Path-Check#785) Only render mayo clinic link when language is english (Path-Check#782) fix(UX) Fix pulse alignment on Android devices with “notch” (Path-Check#771) fix(Location) Improve location "tracking" status checks (Path-Check#749) Fix text crop in About screen (Path-Check#774) [iOS] add missing languages (Path-Check#773)
monaabd27
pushed a commit
to monaabd27/covid-safe-paths
that referenced
this pull request
May 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ignoring apache commons lib
Description:
On the latest develop build (as of May 6, 2020), installing a debug (Android) APK would result in the app throwing a "red box error" (see attached image), that indicated we were missing a crucial dependency. In a release build, this would manifest as the app crashing.
This fix patches the @mauron85/background-geolocation-android module, per the pull request here: mauron85/background-geolocation-android#31, using patch-package, to address its conflicting apache commons dependency, rather than excluding that dependency for the whole project.
Linked issues:
Screenshots:
How to test:
Install an APK and ensure that the app does not crash on loading, or display a red box error (see attached image)