Skip to content

Fix staff runes showing on quarterstaves #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vaisest wants to merge 1 commit into
base: dev
Choose a base branch
from
+2 −2
Open

Fix staff runes showing on quarterstaves #2218

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Classes/ItemsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,7 +1932,7 @@ function ItemsTabClass:GetValidRunesForItem(item)
local function isRuneValidForSlot(runeSlot)
if runeSlot == "None" then
return true
elseif runeSlot == "warstaff" then
elseif runeSlot == "quarterstaff" then
return subType == "warstaff"
elseif runeSlot == "buckler" then
return itemType == "shield" and subType == "evasion"
Expand All @@ -1943,7 +1943,7 @@ function ItemsTabClass:GetValidRunesForItem(item)
elseif runeSlot == "caster" then
return item.base.tags.wand or item.base.tags.staff or item.base.tags.sceptre
else
return itemType == runeSlot
return itemType == runeSlot and not (subType == "warstaff")
end
end
if isRuneValidForSlot(rune.slot) then
Expand Down
Loading