Fix power report and trade search not working with Minions#2219
Open
LocalIdentity wants to merge 1 commit into
Open
Fix power report and trade search not working with Minions#2219LocalIdentity wants to merge 1 commit into
LocalIdentity wants to merge 1 commit into
Conversation
When using the Power Report of a weighted sum trade search, it would not work with minions unless you included them in FullDPS The power report logic was broken due to the invalid lua logic of using "and not selection.stat ==" For the trade search I used the same logic we have in the items tab for using combined DPS as a fallback incase someone selects fullDPS but doesn't add the minion to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When using the Power Report of a weighted sum trade search, it would not work with minions unless you included them in FullDPS
The power report logic was broken due to the invalid lua logic of using "and not selection.stat =="
For the trade search I used the same logic we have in the items tab for using combined DPS as a fallback incase someone selects fullDPS but doesn't add the minion to it
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/7e3gjh0h
Before screenshot:
After screenshot: