Refactor grantedEffectList ordering logic#2234
Open
okazakikun wants to merge 1 commit into
Open
Conversation
Added failsafe for grantedEffectDisplayOrder in cases where there are more effects granted than arguments in grantedEffectDisplayOrder to resolve "MetaMirageArcherPlayer" being discarded and thus spirit not being reserved for mirage archer and potentially other skills.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added fail-safe for grantedEffectDisplayOrder in cases where there are more effects granted than arguments in grantedEffectDisplayOrder to resolve "MetaMirageArcherPlayer" being discarded and thus spirit not being reserved for mirage archer and potentially other skills.
Fixes Mirage archer not reserving spirit as reported in issue 2151
Description of the problem being solved: In Gems.lua SkillGemMirageArcher grants 3 effects but only assigning an order to 2 of them "grantedEffectDisplayOrder = { 1, 2 },"
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://maxroll.gg/poe2/pob/bh7ilp0w
Before screenshot:
After screenshot: