Fix for Chieftain resist nodes applying effects twice due to Foulborn Choir of the Storm#9643
Merged
LocalIdentity merged 2 commits intoApr 17, 2026
Conversation
…nodes applying effects twice due to Foulborn Choir of the Storm
LocalIdentity
approved these changes
Apr 17, 2026
LocalIdentity
left a comment
LocalIdentity
left a comment
Contributor
There was a problem hiding this comment.
I changed it to use a fake actor and also added a test in case this breaks again in the future
mauriceco2424
added a commit
to mauriceco2424/PathOfBuilding
that referenced
this pull request
Jun 16, 2026
Key changes: - Imbued Supports system (PathOfBuildingCommunity#9670) — replaces alternate quality code (PathOfBuildingCommunity#9758), with follow-up fixes for gem list visibility (PathOfBuildingCommunity#9782, PathOfBuildingCommunity#9796), trigger supports (PathOfBuildingCommunity#9793), and indexing bugs (PathOfBuildingCommunity#9763). This is the in-league replacement for Awakened gems and changes how transfigured supports scale. - Calc fixes wave: skills that can repeat (PathOfBuildingCommunity#9723), Vaal Flameblast base AoE (PathOfBuildingCommunity#9704), Generals Cry clones restricted by attack time, Maven Memory Game damage (PathOfBuildingCommunity#9757), Hextoad breakdown (PathOfBuildingCommunity#9683), CwC crash with multiple link groups (PathOfBuildingCommunity#9682), Searing Bond of Detonation power charges (PathOfBuildingCommunity#9695), Tinctures applying without Mana (PathOfBuildingCommunity#9769), Ghost Reaver leech with Life Leech sources (PathOfBuildingCommunity#9774), Poisonous Concoction added damage from disabled life flasks (PathOfBuildingCommunity#9339), Blade Blast of Dagger Detonation Varunastra counting (PathOfBuildingCommunity#9733), converted damage with poison stacks (PathOfBuildingCommunity#8991), Chieftain resist nodes Foulborn Choir double-apply (PathOfBuildingCommunity#9643), Turbulent catalyst flat lightning scaling (PathOfBuildingCommunity#9775), some buffs applying to player and minions wrongly (PathOfBuildingCommunity#9789), negative eHP and NaN Max hit (PathOfBuildingCommunity#9772), Dual Wield mastery thrusting+non-thrusting (PathOfBuildingCommunity#9761). - Ring slot 3 fixes (PathOfBuildingCommunity#9686, PathOfBuildingCommunity#9730) — mods applying when Unseen Hand isn't allocated. - Build comparison tab (PathOfBuildingCommunity#9543) — pure UI, headless mode unaffected. - New spectres: Conjuror of Rot (PathOfBuildingCommunity#9702), Unholy Aberration (PathOfBuildingCommunity#9731). - Trader improvements (PathOfBuildingCommunity#9691), Watcher's eye trade search (PathOfBuildingCommunity#9649), duplicate-search fix (PathOfBuildingCommunity#9767), stale state guard (PathOfBuildingCommunity#9742). - Lesson of Seasons spell barkskin mod (PathOfBuildingCommunity#9820). - Lingering Blades extends to Animate Weapon of Ranged Arms. - Runtime DLLs bumped to SimpleGraphic v2.5.3 (PathOfBuildingCommunity#9395) — affects desktop PoB UI only; headless API runtime is the bundled LuaJIT. - Releases 2.64.0 and 2.65.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9481 .
Description of the problem being solved:
Foulborn Choir of the Storm's increased mana by overcapped lightning resist mod causes resistance conversion mods, such as Taslio, Cleansing Water, to apply twice in calculations.
This is due to how Foulborn Choir of the Storm is handled in the calculations. Since it calls the resistance, mana and reservation calculations again, it adds resistance conversion mods twice as well.
Fix just adds a flag so resistance conversion mods aren't processed twice on accident.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/5cSHvaw15MUI (Screenshots based off this PoB)
https://pobb.in/V41O4IvnojAr (extra case, ES aligns with user report but I'm uncertain mana is accurate as they're saying the in-game UI is bugged. The increased mana aligns with what they're reporting.)
Before screenshot:
After screenshot: