trader tool: fix different searches overwriting the last query#9767
Merged
LocalIdentity merged 1 commit intoApr 16, 2026
Merged
Conversation
LocalIdentity
approved these changes
Apr 16, 2026
mcagnion
added a commit
to mcagnion/PathOfBuilding
that referenced
this pull request
Apr 16, 2026
Display the current step (Search, Search 2..., etc.) and fetch progress (fetched/total...) directly on the "Find best" and "Price Item" buttons instead of only showing "Searching...". This gives feedback during the weighted recursion and during the block-by-block fetch. - TradeQueryRequests: plumb onSearchStart(step) and onFetchProgress(fetched, total) callbacks through SearchWithQuery, SearchWithQueryWeightAdjusted, FetchResults and SearchWithURL. - TradeQuery: each button now drives its own label; bestButton is kept disabled while its label is not "Find best", priceButton while its label is not "Price Item". - Add local m_min = math.min in TradeQueryRequests (also fixes an existing undefined reference used in the 429 retry backoff). - Drive-by: convert one pre-existing space-indented line in TradeQuery.lua to tabs so the pre-commit hook accepts the staged file. Ported onto current origin/dev (adapted for PathOfBuildingCommunity#9691 popup/SearchWithURL query-arg, PathOfBuildingCommunity#9767 lastQueries[row_idx], and the extracted UpdateDropdownList method). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mcagnion
added a commit
to mcagnion/PathOfBuilding
that referenced
this pull request
Apr 16, 2026
Adds checkboxes on the Trade tab to reuse the currently equipped item's Eldritch implicits and amulet anoint when evaluating and displaying trade results. Also adds an "Include unusable" checkbox (UI only, filter logic not yet wired -- hence WIP). Routes result-item construction through a new TradeQueryClass:BuildResultItemWithOverrides helper used by GetResultEvaluation, UpdateDropdownList, the result tooltip and the Import Item button so overrides apply consistently. Port adapted to upstream changes: - PathOfBuildingCommunity#9691 removed enchantInSort/sort algorithm rework: dropped the conditional enchantModLines stripping; the new useCurrentAmuletEnchant checkbox replaces the only remaining meaningful use. - PathOfBuildingCommunity#9767 lastQueries[row_idx]: already in place, no conflict. - PathOfBuildingCommunity#9744 dropdown list refactor: plugged BuildResultItemWithOverrides into UpdateDropdownList instead of the old inline loop. Dropped the unused isEldritch helper from the original diff (it was defined but never called). includeUnusable checkbox state is plumbed but not yet consumed by any query/filter. Also fixes one pre-existing space-indented line in the same function that the pre-commit hook rejected. WIP -- upstream of feature/trade-query-current-item-overrides marked WIP (commit 2a7ad4a "WIP Keep implicits"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mcagnion
added a commit
to mcagnion/PathOfBuilding
that referenced
this pull request
Apr 18, 2026
Adds checkboxes on the Trade tab to reuse the currently equipped item's Eldritch implicits and amulet anoint when evaluating and displaying trade results. Also adds an "Include unusable" checkbox (UI only, filter logic not yet wired -- hence WIP). Routes result-item construction through a new TradeQueryClass:BuildResultItemWithOverrides helper used by GetResultEvaluation, UpdateDropdownList, the result tooltip and the Import Item button so overrides apply consistently. Port adapted to upstream changes: - PathOfBuildingCommunity#9691 removed enchantInSort/sort algorithm rework: dropped the conditional enchantModLines stripping; the new useCurrentAmuletEnchant checkbox replaces the only remaining meaningful use. - PathOfBuildingCommunity#9767 lastQueries[row_idx]: already in place, no conflict. - PathOfBuildingCommunity#9744 dropdown list refactor: plugged BuildResultItemWithOverrides into UpdateDropdownList instead of the old inline loop. Dropped the unused isEldritch helper from the original diff (it was defined but never called). includeUnusable checkbox state is plumbed but not yet consumed by any query/filter. Also fixes one pre-existing space-indented line in the same function that the pre-commit hook rejected. WIP -- upstream of feature/trade-query-current-item-overrides marked WIP (commit 2a7ad4a "WIP Keep implicits"). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mcagnion
added a commit
to mcagnion/PathOfBuilding
that referenced
this pull request
Apr 18, 2026
Display the current step (Search, Search 2..., etc.) and fetch progress (fetched/total...) directly on the "Find best" and "Price Item" buttons instead of only showing "Searching...". This gives feedback during the weighted recursion and during the block-by-block fetch. - TradeQueryRequests: plumb onSearchStart(step) and onFetchProgress(fetched, total) callbacks through SearchWithQuery, SearchWithQueryWeightAdjusted, FetchResults and SearchWithURL. - TradeQuery: each button now drives its own label; bestButton is kept disabled while its label is not "Find best", priceButton while its label is not "Price Item". - Add local m_min = math.min in TradeQueryRequests (also fixes an existing undefined reference used in the 429 retry backoff). - Drive-by: convert one pre-existing space-indented line in TradeQuery.lua to tabs so the pre-commit hook accepts the staged file. Ported onto current origin/dev (adapted for PathOfBuildingCommunity#9691 popup/SearchWithURL query-arg, PathOfBuildingCommunity#9767 lastQueries[row_idx], and the extracted UpdateDropdownList method). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
mauriceco2424
added a commit
to mauriceco2424/PathOfBuilding
that referenced
this pull request
Jun 16, 2026
Key changes: - Imbued Supports system (PathOfBuildingCommunity#9670) — replaces alternate quality code (PathOfBuildingCommunity#9758), with follow-up fixes for gem list visibility (PathOfBuildingCommunity#9782, PathOfBuildingCommunity#9796), trigger supports (PathOfBuildingCommunity#9793), and indexing bugs (PathOfBuildingCommunity#9763). This is the in-league replacement for Awakened gems and changes how transfigured supports scale. - Calc fixes wave: skills that can repeat (PathOfBuildingCommunity#9723), Vaal Flameblast base AoE (PathOfBuildingCommunity#9704), Generals Cry clones restricted by attack time, Maven Memory Game damage (PathOfBuildingCommunity#9757), Hextoad breakdown (PathOfBuildingCommunity#9683), CwC crash with multiple link groups (PathOfBuildingCommunity#9682), Searing Bond of Detonation power charges (PathOfBuildingCommunity#9695), Tinctures applying without Mana (PathOfBuildingCommunity#9769), Ghost Reaver leech with Life Leech sources (PathOfBuildingCommunity#9774), Poisonous Concoction added damage from disabled life flasks (PathOfBuildingCommunity#9339), Blade Blast of Dagger Detonation Varunastra counting (PathOfBuildingCommunity#9733), converted damage with poison stacks (PathOfBuildingCommunity#8991), Chieftain resist nodes Foulborn Choir double-apply (PathOfBuildingCommunity#9643), Turbulent catalyst flat lightning scaling (PathOfBuildingCommunity#9775), some buffs applying to player and minions wrongly (PathOfBuildingCommunity#9789), negative eHP and NaN Max hit (PathOfBuildingCommunity#9772), Dual Wield mastery thrusting+non-thrusting (PathOfBuildingCommunity#9761). - Ring slot 3 fixes (PathOfBuildingCommunity#9686, PathOfBuildingCommunity#9730) — mods applying when Unseen Hand isn't allocated. - Build comparison tab (PathOfBuildingCommunity#9543) — pure UI, headless mode unaffected. - New spectres: Conjuror of Rot (PathOfBuildingCommunity#9702), Unholy Aberration (PathOfBuildingCommunity#9731). - Trader improvements (PathOfBuildingCommunity#9691), Watcher's eye trade search (PathOfBuildingCommunity#9649), duplicate-search fix (PathOfBuildingCommunity#9767), stale state guard (PathOfBuildingCommunity#9742). - Lesson of Seasons spell barkskin mod (PathOfBuildingCommunity#9820). - Lingering Blades extends to Animate Weapon of Ranged Arms. - Runtime DLLs bumped to SimpleGraphic v2.5.3 (PathOfBuildingCommunity#9395) — affects desktop PoB UI only; headless API runtime is the bundled LuaJIT. - Releases 2.64.0 and 2.65.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Fixes an issue on my previous PR where searching different categories overwrites the last query, and searches the wrong item when clicking the search button.