Skip to content

Fix crash on selecting some Imbued gems + trigger supports not working#9793

Merged
LocalIdentity merged 2 commits into
devfrom
fix_imbued
Apr 20, 2026
Merged

Fix crash on selecting some Imbued gems + trigger supports not working#9793
LocalIdentity merged 2 commits into
devfrom
fix_imbued

Conversation

@LocalIdentity

Copy link
Copy Markdown
Contributor

Description of the problem being solved:

Fixes the crash that occurred when an imbued support tried to grant a active skill
Fixes imbued supports that granted a secondary granted effect like cast on crit, cast when damage taken or cast while channeling

Steps taken to verify a working solution:

Link to a build that showcases this PR:

Before screenshot:

After screenshot:

LocalIdentity added 2 commits April 20, 2026 22:24
Support gems like Prismatic Burst of Summon Wisps are not valid imbued supports as they grant active skills
Secondary granted effects from supports like cast on crit or cast when damage taken weren't working as we were not adding the secondary granted effects
@LocalIdentity LocalIdentity added bug: calculation Numerical differences crash Causes PoB to crash and is High Priority labels Apr 20, 2026
@LocalIdentity LocalIdentity merged commit 99d458b into dev Apr 20, 2026
3 checks passed
@LocalIdentity LocalIdentity deleted the fix_imbued branch April 20, 2026 17:28
mauriceco2424 added a commit to mauriceco2424/PathOfBuilding that referenced this pull request Jun 16, 2026
Key changes:
- Imbued Supports system (PathOfBuildingCommunity#9670) — replaces alternate quality code (PathOfBuildingCommunity#9758),
  with follow-up fixes for gem list visibility (PathOfBuildingCommunity#9782, PathOfBuildingCommunity#9796), trigger
  supports (PathOfBuildingCommunity#9793), and indexing bugs (PathOfBuildingCommunity#9763). This is the in-league
  replacement for Awakened gems and changes how transfigured supports
  scale.
- Calc fixes wave: skills that can repeat (PathOfBuildingCommunity#9723), Vaal Flameblast base
  AoE (PathOfBuildingCommunity#9704), Generals Cry clones restricted by attack time, Maven
  Memory Game damage (PathOfBuildingCommunity#9757), Hextoad breakdown (PathOfBuildingCommunity#9683), CwC crash with
  multiple link groups (PathOfBuildingCommunity#9682), Searing Bond of Detonation power charges
  (PathOfBuildingCommunity#9695), Tinctures applying without Mana (PathOfBuildingCommunity#9769), Ghost Reaver leech
  with Life Leech sources (PathOfBuildingCommunity#9774), Poisonous Concoction added damage
  from disabled life flasks (PathOfBuildingCommunity#9339), Blade Blast of Dagger Detonation
  Varunastra counting (PathOfBuildingCommunity#9733), converted damage with poison stacks
  (PathOfBuildingCommunity#8991), Chieftain resist nodes Foulborn Choir double-apply (PathOfBuildingCommunity#9643),
  Turbulent catalyst flat lightning scaling (PathOfBuildingCommunity#9775), some buffs applying
  to player and minions wrongly (PathOfBuildingCommunity#9789), negative eHP and NaN Max hit
  (PathOfBuildingCommunity#9772), Dual Wield mastery thrusting+non-thrusting (PathOfBuildingCommunity#9761).
- Ring slot 3 fixes (PathOfBuildingCommunity#9686, PathOfBuildingCommunity#9730) — mods applying when Unseen Hand
  isn't allocated.
- Build comparison tab (PathOfBuildingCommunity#9543) — pure UI, headless mode unaffected.
- New spectres: Conjuror of Rot (PathOfBuildingCommunity#9702), Unholy Aberration (PathOfBuildingCommunity#9731).
- Trader improvements (PathOfBuildingCommunity#9691), Watcher's eye trade search (PathOfBuildingCommunity#9649),
  duplicate-search fix (PathOfBuildingCommunity#9767), stale state guard (PathOfBuildingCommunity#9742).
- Lesson of Seasons spell barkskin mod (PathOfBuildingCommunity#9820).
- Lingering Blades extends to Animate Weapon of Ranged Arms.
- Runtime DLLs bumped to SimpleGraphic v2.5.3 (PathOfBuildingCommunity#9395) — affects desktop
  PoB UI only; headless API runtime is the bundled LuaJIT.
- Releases 2.64.0 and 2.65.0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug: calculation Numerical differences crash Causes PoB to crash and is High Priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant