Change code style to preserve type hints and improve static analysis capabilities by vaisest · Pull Request #9861 · PathOfBuildingCommunity/PathOfBuilding

Add global API type hints

vaisest

committed

Update .emmyrc.json instructions

vaisest

committed

Fix typo

vaisest

committed

Add missing func parameters and recommend skipping the rest of the tests

vaisest

committed

Fix definition file

vaisest

committed

Improve type hinting for classes by:

vaisest

committed

Add lsp config to gitignore

vaisest

committed

Change class constructor to be added as a separate method, instead of being an argument to newClass

vaisest

committed

Declare Build as a type

vaisest

committed

Move HeadlessWrapper.lua dummy functions to def file

vaisest

committed

Add more handle class type hints, and fix typo

vaisest

committed

Misc fixes

vaisest

committed

Require self to be supplied to parent constructors manually (using `:`) to fix type checking

vaisest

committed

Change class constructors to call the constructor directly, instead of using new() and varargs

vaisest

committed

Update data export class definitions

vaisest

committed

Update def file callback variable

vaisest

committed

Describe emmylua alternative in CONTRIBUTING.md

vaisest

committed

Explicitly return self from constructors to preserve type information

vaisest

committed

Fix control type hint and toastnotification constructor syntax

vaisest

committed

Recommend avoiding HeadlessWrapper for language server

vaisest

committed

Remove varargs from new() and recommend treating LoadModule like require using config

vaisest

committed

Recommend some luals addons for test framework definitions

vaisest

committed

Fix cspell error and add mod type examples

vaisest

committed

White space fixes

vaisest

committed

Add missing SimpleGraphic definitions and recommend including them as a library

vaisest

committed

Convert all modules to be compatible with require()

vaisest

committed

Fix typo

vaisest

committed

Remove print from def file

vaisest

committed

Fix tests

vaisest

committed

Disable test. Fixed in another PR

vaisest

committed

Fix modCache being dropped during load

vaisest

committed

Fix update script

vaisest

committed

Fix calc typos

vaisest

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change code style to preserve type hints and improve static analysis capabilities#9861

Change code style to preserve type hints and improve static analysis capabilities#9861
vaisest wants to merge 33 commits into
PathOfBuildingCommunity:devfrom
vaisest:typing

Commits on Jun 14, 2026

Add global API type hints

Update .emmyrc.json instructions

Fix typo

Add missing func parameters and recommend skipping the rest of the tests

Fix definition file

Improve type hinting for classes by:

Add lsp config to gitignore

Change class constructor to be added as a separate method, instead of being an argument to newClass

Declare Build as a type

Move HeadlessWrapper.lua dummy functions to def file

Add more handle class type hints, and fix typo

Misc fixes

Require self to be supplied to parent constructors manually (using `:`) to fix type checking

Change class constructors to call the constructor directly, instead of using new() and varargs

Update data export class definitions

Update def file callback variable

Describe emmylua alternative in CONTRIBUTING.md

Explicitly return self from constructors to preserve type information

Fix control type hint and toastnotification constructor syntax

Recommend avoiding HeadlessWrapper for language server

Remove varargs from new() and recommend treating LoadModule like require using config

Recommend some luals addons for test framework definitions

Fix cspell error and add mod type examples

White space fixes

Add missing SimpleGraphic definitions and recommend including them as a library

Convert all modules to be compatible with require()

Fix typo

Remove print from def file

Fix tests

Disable test. Fixed in another PR

Fix modCache being dropped during load

Fix update script

Fix calc typos