Use tag selector in case title has a space in#1
Open
alexjbest wants to merge 1 commit intoPatrickMassot:masterfrom
Open
Use tag selector in case title has a space in#1alexjbest wants to merge 1 commit intoPatrickMassot:masterfrom
alexjbest wants to merge 1 commit intoPatrickMassot:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In https://github.com/PatrickMassot/leanblueprint/blob/master/leanblueprint/templates/dep_graph.html#L137 the code
is used to select elements with a given id, this id is generated from the labels in the tex source, and this fails to select the element if this label contains spaces.
We hit this issue in leanprover-community/flt-regular as the blueprint was converted from some pre-existing notes where the labels did have spaces in.
Following https://stackoverflow.com/questions/596314/jquery-ids-with-spaces we change the selector to allow spaces in the id.
I haven't been able to test this change yet.