You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After first start the configuration parameter "Interface theme" is empty in the GUI, i.e. it is not "smoothness":
If you just change the recording path configuration (or nothing at all) and press "Submit changes" the current theme suddenly is lost. Example screenshot shows the channels page:
Root cause for this is wrong default setting of the theme in config.py and tvstreamrecord.py.
(Please note that in the 2 files there are different line ending characters for a few lines which was automatically fixed by the code editor on save. That's the reason why the diffs show these lines, too.)
Sorry, I've missed your PR, just saw it now. It's a strange behavior here.
It seems to me, jquery-ui.min.css is a proper CSS, using theme.css from the same folder fails for me.
Your fix is not working proper on my quick Windows setup.
Anyway the theme selection is error prone, I'll look into it as soon as I can.
Thanks for pointing it out!
I've looked into this today and it's a curious bug.
I'm sure I've seen this error myself but I wasn't able to reproduce it in a fresh setup. It might have happened due to version or database migration or some misconfiguration
As already written, larger jquery-ui.min.css is the necessary one, theme.css is not. In fact, if you look into any jquery-ui.min.css, you'll see:
The theme selection itself is flawed and selects first css from a theme folder:
So normally this should select an alphabetic first file jquery-ui.min.css. On some system it probably could select theme.css instead, which would lead to the error.
As I'm too lazy to rewrite this function, I'd rather delete all theme.css from all folders thus reducing the overall footprint. On both Win and Linux with both Py2 and Py3 it looks proper.
There is a bug in the code you've addressed: while config.py default setting is right and should not be changed, tvstreamrecord.py fallback is wrong:
Instead of my code or your proposal it should be:
config.cfg_theme = "smoothness/jquery-ui.min.css"
This wrong fallback setting could too have triggered the same error but shouldn't fire under any circumstances.
Anyway, I'll fix it after merging the first PR.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After first start the configuration parameter "Interface theme" is empty in the GUI, i.e. it is not "smoothness":
If you just change the recording path configuration (or nothing at all) and press "Submit changes" the current theme suddenly is lost. Example screenshot shows the channels page:
Root cause for this is wrong default setting of the theme in config.py and tvstreamrecord.py.
(Please note that in the 2 files there are different line ending characters for a few lines which was automatically fixed by the code editor on save. That's the reason why the diffs show these lines, too.)