Temp tables: Delimit identifier for primary key columns#73
Merged
PawelGerr merged 1 commit intoPawelGerr:releases/10.0.xfrom Feb 22, 2026
Merged
Temp tables: Delimit identifier for primary key columns#73PawelGerr merged 1 commit intoPawelGerr:releases/10.0.xfrom
PawelGerr merged 1 commit intoPawelGerr:releases/10.0.xfrom
Conversation
oronf-mda
changed the title
Owner
|
Thx, please rebase the PR onto |
Contributor
Author
|
@PawelGerr done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case: For SQL Server, when inserting into a temp table with a defined primary key, and the key is created after insertion, the column names were not escaped. This caused an error when a column name is the same as an SQL keyword (such as
Key).The fix:
DelimitIdentifierfor each column name, similarly to the other methods.