Open
Conversation
piequi
force-pushed
the
fix/send-pending-records
branch
from
fe58010 to
59b3b54
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11
This PR adds 2 new parameters to the plugin configuration:
SQSEndpointandflushPendingRecordsStringSQSEndpointwas introduced as a convenience to be able to use Locastack SQS queue to experiment around.flushPendingRecordsStringis a boolean parameter that will allow flushing pending records (as described in the issue) to be sent following fluentbit'sFlushperiod. If the records count provided to the plugin when callingFLBPluginFlushCtx()isn't a multiple ofbatchSizethen the remaining records will be sent in a smaller SQS message batch.As I'm not very knowledeable regarding GO module packaging, I don't know if the dependencies update are concerning or not.