This repository was archived by the owner on Mar 5, 2024. It is now read-only.
made a few comments in the gui files, some may not be correct I need …#229
Open
CPQE wants to merge 1 commit into
Open
made a few comments in the gui files, some may not be correct I need …#229CPQE wants to merge 1 commit into
CPQE wants to merge 1 commit into
Conversation
…someone to walk me through some of it because the C++ style is kind of confusing
SammCheese
approved these changes
Nov 15, 2020
SammCheese
left a comment
SammCheese
left a comment
There was a problem hiding this comment.
Looks Good, a few misspellings but overall fairly understandable
Note: try to keep opinions out of the comments and instead list them in Issues (MainWindow.cpp - Line 318- 320)
ClusterConsultant
added
Priority: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
someone to walk me through some of it because the C++ style is kind of confusing.
This will be my first PR so please give me feedback.