Skip to content

feat(sidebar): improve thread preview limit and empty project UX#3

Merged
jwangkun merged 1 commit into
PeakCode-AI:mainfrom
Neonity2020:feature/sidebar-improvements
Jun 9, 2026
Merged

feat(sidebar): improve thread preview limit and empty project UX#3
jwangkun merged 1 commit into
PeakCode-AI:mainfrom
Neonity2020:feature/sidebar-improvements

Conversation

@Neonity2020

@Neonity2020 Neonity2020 commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Summary

改进 Sidebar 的线程预览限制和空项目状态的用户体验。

Changes

  • 提取 SIDEBAR_THREAD_PREVIEW_LIMIT 常量以保持一致性
  • 为空项目状态添加友好的 UI,包含文件夹选择器按钮
  • 添加国际化消息(英文/中文)
  • 改进 macOS 图标生成的错误处理
  • 移除 "Type path" 手动输入机制:简化添加项目流程,统一使用文件夹选择器

Files changed

  • Sidebar.logic.ts - 导出线程预览限制常量
  • Sidebar.logic.test.ts - 添加相关测试
  • Sidebar.tsx - 空状态 UI 优化,移除手动输入 UI
  • messages.ts - i18n 消息
  • build-desktop-artifact.ts - 图标生成容错

🤖 Generated with Claude Code

@github-actions github-actions Bot added size:M vouch:unvouched PR author is not yet trusted in the VOUCHED list. labels Jun 9, 2026
- Extract SIDEBAR_THREAD_PREVIEW_LIMIT constant for consistency
- Add helpful empty state UI with folder picker button
- Add i18n messages for empty state and folder picker
- Improve macOS icon generation error handling with fallback

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@Neonity2020 Neonity2020 force-pushed the feature/sidebar-improvements branch from aa9030b to 5385b14 Compare June 9, 2026 22:07
@github-actions github-actions Bot added size:L and removed size:M labels Jun 9, 2026

@jwangkun jwangkun left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR 审查报告

结论:通过 ✅ 可以合并

审查摘要

维度 结果 说明
问题修复 提取 SIDEBAR_THREAD_PREVIEW_LIMIT 常量,修复旧代码中 THREAD_PREVIEW_LIMIT=5 与 TODO 要求 10 的不一致
代码规范 ✅ 通过 typecheck / lint / fmt 全部通过
与项目方向对齐 简化 Sidebar 添加项目流程符合"performance first"和UI简化方向;i18n 支持符合项目多语言需求

详细分析

1. Sidebar.logic.ts / Sidebar.tsx — 常量提取 ✅

  • 将本地 THREAD_PREVIEW_LIMIT = 5 替换为导出的 SIDEBAR_THREAD_PREVIEW_LIMIT = 10
  • 与 TODO.md "Only show last 10 threads" 保持一致,方向正确

2. Sidebar.tsx — 移除手动输入路径 + 统一使用文件夹选择器 ✅

  • 简化了添加项目 UI,统一使用文件夹选择器
  • Empty state 增加 "选择项目文件夹" 按钮,提升新用户引导体验
  • 注意:非 Electron 环境(dev 模式)失去手动输入路径能力,但项目为 Electron-first,可接受

3. Sidebar.logic.test.ts — 新增测试 ✅

  • 验证 SIDEBAR_THREAD_PREVIEW_LIMIT === 10

4. i18n/messages.ts — 国际化 ✅

  • 新增 4 个 key,中英文完整覆盖

5. scripts/build-desktop-artifact.ts — macOS 图标容错 ✅

  • 使用 Effect.catch 优雅处理 iconset 生成失败场景

改进建议(非阻塞)

  • 后续如支持非 Electron 环境,可考虑加回"手动输入路径"作为 fallback
  • CONTRIBUTING.md 的表格格式调整建议与主功能拆分为独立 PR,减少审查噪音

按 AGENTS.md 要求,已运行:

  • bun fmt:check
  • bun typecheck
  • bun lint
  • bun run test ✅(ChatMarkdown.test.tsx 的 KaTeX 失败为已有 pre-existing 问题,与 PR 无关)

@jwangkun jwangkun merged commit 640cb02 into PeakCode-AI:main Jun 9, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants