feat(clickhouse): another approach for TLS certificate from secret#3938
Draft
feat(clickhouse): another approach for TLS certificate from secret#3938
Conversation
Adds `tls_certificate_secret_name` ClickHouse config that is used to dynamically load TLS certificate from Kubernetes secret, in a format compatible with `cert-manager`. (https://cert-manager.io/docs/usage/certificate/) Feature is gated with `PEERDB_CLICKHOUSE_TLS_K8S_SECRET_ENABLED` and enabled by default. It enables to force fallback into inline certificate. This comes with a little refactor to ClickHouse Connect function.
|
|
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's an alternative approach to #3929.
Summary
tls_certificate_directory).PeerValidationFlagsfrom proto definitions and all related UI/handler plumbing (skip-validation toggle).k8s_secret_store.go(~220 lines) and its tests (~300 lines), removesPEERDB_CLICKHOUSE_TLS_K8S_SECRET_ENABLEDdynamic config setting.