Skip to content

support dots in identifiers#4052

Open
serprex wants to merge 4 commits intomainfrom
mysql-dot
Open

support dots in identifiers#4052
serprex wants to merge 4 commits intomainfrom
mysql-dot

Conversation

@serprex
Copy link
Copy Markdown
Member

@serprex serprex commented Mar 13, 2026

double dot is used to escape dots, like %% in format strings

@serprex serprex force-pushed the mysql-dot branch 2 times, most recently from c80de85 to 1c63544 Compare March 13, 2026 13:44
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026 •
edited
Loading

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
2066 10 2056 223
View the top 3 failed test(s) by shortest run time 
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ
Stack Traces | 0s run time 
=== RUN   TestGenericBQ
=== PAUSE TestGenericBQ
=== CONT  TestGenericBQ
--- FAIL: TestGenericBQ (0.00s)
2026/03/24 20:03:06 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/24 20:03:06 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/24 20:03:06 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychcl_rovkejqb.test_time

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericCH_PG
Stack Traces | 0s run time 
=== RUN   TestGenericCH_PG
=== PAUSE TestGenericCH_PG
=== CONT  TestGenericCH_PG
--- FAIL: TestGenericCH_PG (0.00s)
2026/03/24 19:58:03 INFO fetched schema x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} table=e2e_test_mychclg_evwke9hq.test_simple_schema_changes

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG
Stack Traces | 0s run time 
=== RUN   TestGenericPG
=== PAUSE TestGenericPG
=== CONT  TestGenericPG
--- FAIL: TestGenericPG (0.00s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericSF
Stack Traces | 0s run time 
=== RUN   TestGenericSF
=== PAUSE TestGenericSF
=== CONT  TestGenericSF
--- FAIL: TestGenericSF (0.00s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericChCluster_PG
Stack Traces | 0.01s run time 
=== RUN   TestGenericChCluster_PG
=== PAUSE TestGenericChCluster_PG
=== CONT  TestGenericChCluster_PG
--- FAIL: TestGenericChCluster_PG (0.01s)
2026/03/24 20:00:24 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/24 20:00:24 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
View the full list of 5 ❄️ flaky test(s) 
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering

Flake rate in main: 24.64% (Passed 156 times, Failed 51 times)

Stack Traces | 1.27s run time 
=== RUN   TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering
=== PAUSE TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering
=== CONT  TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering
2026/03/24 20:01:06 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id"
2026/03/24 20:01:06 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id"
2026/03/24 20:01:06 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_13244488704254336768 CURSOR FOR SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id" args=[]
2026/03/24 20:01:06 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id" channelLen=0
2026/03/24 20:01:06 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_13244488704254336768
2026/03/24 20:01:06 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_13244488704254336768 records=2 bytes=12 channelLen=1
2026/03/24 20:01:06 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id" rows=2 bytes=12 channelLen=1
2026/03/24 20:01:06 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_13244488704254336768
2026/03/24 20:01:06 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_13244488704254336768 records=0 bytes=0 channelLen=0
2026/03/24 20:01:06 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/03/24 20:01:06 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/03/24 20:01:06 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column\" ORDER BY id" rows=2 bytes=12 channelLen=0
2026/03/24 20:01:06 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column_dst\" ORDER BY id"
2026/03/24 20:01:06 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column_dst\" ORDER BY id"
2026/03/24 20:01:06 INFO [pg_query_executor] failed to declare cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_941823267957979722 CURSOR FOR SELECT id, col_to_add FROM e2e_test_pg_uq28supj.\"test_ddl_drop_column_dst\" ORDER BY id" args=[] error="ERROR: column \"col_to_add\" does not exist (SQLSTATE 42703)"
2026/03/24 20:01:06 ERROR [pg_query_executor] failed to execute and process query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart error="[pg_query_executor] failed to declare cursor: ERROR: column \"col_to_add\" does not exist (SQLSTATE 42703)"
    generic_test.go:505: 
        	Error Trace:	.../flow/e2e/generic_test.go:505
        	Error:      	Received unexpected error:
        	            	ERROR: syntax error at or near "_p1" (SQLSTATE 42601)
        	Test:       	TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering
    bigquery.go:86: begin tearing down postgres schema bq_3fiephm0_20260324200106
2026/03/24 20:01:07 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id"
2026/03/24 20:01:07 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id"
2026/03/24 20:01:07 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_14465157599588255330 CURSOR FOR SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id" args=[]
2026/03/24 20:01:07 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id" channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14465157599588255330
2026/03/24 20:01:07 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14465157599588255330 records=10 bytes=230 channelLen=9
2026/03/24 20:01:07 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id" rows=10 bytes=230 channelLen=9
2026/03/24 20:01:07 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14465157599588255330
2026/03/24 20:01:07 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_14465157599588255330 records=0 bytes=0 channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/03/24 20:01:07 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition\" ORDER BY id" rows=10 bytes=230 channelLen=0
2026/03/24 20:01:07 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id"
2026/03/24 20:01:07 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id"
2026/03/24 20:01:07 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_8164584059038036572 CURSOR FOR SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id" args=[]
2026/03/24 20:01:07 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id" channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8164584059038036572
2026/03/24 20:01:07 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8164584059038036572 records=10 bytes=230 channelLen=9
2026/03/24 20:01:07 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id" rows=10 bytes=230 channelLen=9
2026/03/24 20:01:07 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8164584059038036572
2026/03/24 20:01:07 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_8164584059038036572 records=0 bytes=0 channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/03/24 20:01:07 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/03/24 20:01:07 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_pg_gxeudjqa.\"test_partition_dst\" ORDER BY id" rows=10 bytes=230 channelLen=0
--- FAIL: TestGenericBQ/Test_Partitioned_Table_With_Different_Column_Ordering (1.27s)
2026/03/24 20:01:07 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,c1,coalesce(c3,0) c3 FROM e2e_test_pg_qw9hyo68.\"test_simple_schema_changes\" ORDER BY id"

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering

Flake rate in main: 24.64% (Passed 156 times, Failed 51 times)

Stack Traces | 0.04s run time 
=== RUN   TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering
=== PAUSE TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering
=== CONT  TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering
2026/03/24 19:56:43 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/24 19:56:43 INFO [schema delta replay] added column ±ªÞ³§ with data type STRING x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} "destination table name"=PUBLIC.ADD_DROP_TRICKY_COLUMN_NAMES "source table name"=PUBLIC.ADD_DROP_TRICKY_COLUMN_NAMES
    generic_test.go:505: 
        	Error Trace:	.../flow/e2e/generic_test.go:505
        	Error:      	Received unexpected error:
        	            	ERROR: syntax error at or near "_p1" (SQLSTATE 42601)
        	Test:       	TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering
    clickhouse.go:112: begin tearing down postgres schema pgchg_tif5dg0n
--- FAIL: TestGenericCH_PG/Test_Partitioned_Table_With_Different_Column_Ordering (0.04s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering

Flake rate in main: 24.64% (Passed 156 times, Failed 51 times)

Stack Traces | 0.08s run time 
=== RUN   TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering
=== PAUSE TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering
=== CONT  TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering
2026/03/24 19:58:57 INFO Received AWS credentials from peer for connector: ci x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
2026/03/24 19:58:57 INFO Received AWS credentials from peer for connector: clickhouse x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN}
    generic_test.go:505: 
        	Error Trace:	.../flow/e2e/generic_test.go:505
        	Error:      	Received unexpected error:
        	            	ERROR: syntax error at or near "_p1" (SQLSTATE 42601)
        	Test:       	TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering
    clickhouse.go:112: begin tearing down postgres schema pgchclg_ilazfnqa
--- FAIL: TestGenericChCluster_PG/Test_Partitioned_Table_With_Different_Column_Ordering (0.08s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering

Flake rate in main: 24.64% (Passed 156 times, Failed 51 times)

Stack Traces | 0.02s run time 
=== RUN   TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering
=== PAUSE TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering
=== CONT  TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering
    generic_test.go:505: 
        	Error Trace:	.../flow/e2e/generic_test.go:505
        	Error:      	Received unexpected error:
        	            	ERROR: syntax error at or near "_p1" (SQLSTATE 42601)
        	Test:       	TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering
    postgres.go:92: begin tearing down postgres schema pg_h3juxf12
2026/03/24 20:00:49 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('cancel_table_addition_test_flow_with_removal_api_yzxp7ckj' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_yzxp7ckj.t5_mv_api_yzxp7ckj%'"
2026/03/24 20:00:49 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="\n\t\tSELECT COUNT(*) FROM peerdb_stats.flow_errors\n\t\tWHERE error_type='error' AND position('cancel_table_addition_test_flow_with_removal_api_yzxp7ckj' in flow_name) > 0\n\t\tAND error_message ILIKE '%while pushing to view e2e_test_api_yzxp7ckj.t5_mv_api_yzxp7ckj%'"
--- FAIL: TestGenericPG/Test_Partitioned_Table_With_Different_Column_Ordering (0.02s)

github.com/PeerDB-io/peerdb/flow/e2e::TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering

Flake rate in main: 25.36% (Passed 156 times, Failed 53 times)

Stack Traces | 1.99s run time 
=== RUN   TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering
=== PAUSE TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering
=== CONT  TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering
    generic_test.go:505: 
        	Error Trace:	.../flow/e2e/generic_test.go:505
        	Error:      	Received unexpected error:
        	            	ERROR: syntax error at or near "_p1" (SQLSTATE 42601)
        	Test:       	TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering
    snowflake.go:114: begin tearing down postgres schema sf_tppwjjvm_20260324195824
--- FAIL: TestGenericSF/Test_Partitioned_Table_With_Different_Column_Ordering (1.99s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@serprex serprex force-pushed the mysql-dot branch 3 times, most recently from a5dee0d to 56ecd71 Compare March 13, 2026 15:19
@serprex serprex marked this pull request as draft March 13, 2026 15:19
@serprex serprex force-pushed the mysql-dot branch 4 times, most recently from 3a675ea to e952a7d Compare March 13, 2026 16:37
@serprex serprex requested a review from ilidemi March 13, 2026 16:45
@serprex serprex force-pushed the mysql-dot branch 4 times, most recently from 54182aa to ead136d Compare March 13, 2026 17:55
@serprex serprex marked this pull request as ready for review March 13, 2026 18:14
ilidemi
ilidemi requested changes Mar 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ilidemi ilidemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed before, the proper solution to this is a contract migration to separate schema and table. Here's an example of a recent one doing the db/protos side of it: #3704

@serprex
Copy link
Copy Markdown
Member Author

serprex commented Mar 13, 2026

protobuf doesn't support map[type], keys must be strings

@ilidemi
Copy link
Copy Markdown
Contributor

ilidemi commented Mar 13, 2026

protobuf doesn't support map[type], keys must be strings

It's okay to have those as lists with constructing maps at runtime and validating uniqueness

@serprex serprex force-pushed the mysql-dot branch 3 times, most recently from 12faae1 to ad0c68f Compare March 13, 2026 22:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

❌ Test Failure

Analysis: Unable to access CI logs — gh CLI and web fetch tools are blocked in this environment, so no determination can be made.
Confidence: 0

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 14, 2026

❌ Test Failure

Analysis: Unable to retrieve CI logs due to permission restrictions; please approve the gh CLI command or paste the logs to enable analysis.
Confidence: 0

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@serprex serprex requested a review from Amogh-Bharadwaj March 19, 2026 15:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

❌ Test Failure

Analysis: Real build failure: s.Source().Exec was changed to return 1 value but e2e/clickhouse_test.go still unpacks 2 return values at multiple call sites.
Confidence: 0.99

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

❌ Test Failure

Analysis: Consistent SQL syntax error syntax error at or near "_p1" in Test_Partitioned_Table_With_Different_Column_Ordering across all test suites (PG, CH, SF, BQ), indicating a real bug in SQL generation for partition names starting with an underscore.
Confidence: 0.95

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

❌ Test Failure

Analysis: The test Test_Partitioned_Table_With_Different_Column_Ordering fails consistently across all PG-based suites (CH, SF, PG, BQ, CH Cluster) with a deterministic SQL syntax error "syntax error at or near \"_p1\"" at generic_test.go:505, indicating a real bug in SQL generation for partitioned tables with differing column orderings.
Confidence: 0.97

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

This was referenced Apr 3, 2026
Merged
Draft
@pfcoperez pfcoperez mentioned this pull request Apr 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ilidemi ilidemi ilidemi requested changes

@Amogh-Bharadwaj Amogh-Bharadwaj Awaiting requested review from Amogh-Bharadwaj

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serprex @ilidemi