Skip to content

Fix rerun of local tests#4180

Merged
ilidemi merged 4 commits intomainfrom
fix-local-tests-some
Apr 16, 2026
Merged

Fix rerun of local tests#4180
ilidemi merged 4 commits intomainfrom
fix-local-tests-some

Conversation

@ilidemi
Copy link
Copy Markdown
Contributor

@ilidemi ilidemi commented Apr 15, 2026

  • Cleanup of a toxi test to avoid port conflict on the next run
  • Limit PG slot names as they silently get truncated and chop off the suffix, enforce that for future tests
  • QoL improvement to not rebuild flow services on test file changes

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
2191 2 2189 187
View the top 2 failed test(s) by shortest run time
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ
Stack Traces | 0.01s run time
=== RUN   TestGenericBQ
=== PAUSE TestGenericBQ
=== CONT  TestGenericBQ
--- FAIL: TestGenericBQ (0.01s)
github.com/PeerDB-io/peerdb/flow/e2e::TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting
Stack Traces | 34.5s run time
=== RUN   TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting
=== PAUSE TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting
=== CONT  TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting
    generic_test.go:1103: UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT
    bigquery.go:86: begin tearing down postgres schema bq_pa5i0geq_20260416050749
2026/04/16 05:08:22 INFO Executing and processing query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id"
2026/04/16 05:08:22 INFO Executing and processing query stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id"
2026/04/16 05:08:22 INFO [pg_query_executor] declared cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursorQuery="DECLARE peerdb_cursor_17003312036440541221 CURSOR FOR SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id" args=[]
2026/04/16 05:08:22 INFO [pg_query_executor] fetching rows start x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id" channelLen=0
2026/04/16 05:08:22 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_17003312036440541221
2026/04/16 05:08:22 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_17003312036440541221 records=13 bytes=293 channelLen=12
2026/04/16 05:08:22 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id" rows=13 bytes=293 channelLen=12
2026/04/16 05:08:22 INFO [pg_query_executor] fetching from cursor x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_17003312036440541221
2026/04/16 05:08:22 INFO processed row stream x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart cursor=peerdb_cursor_17003312036440541221 records=0 bytes=0 channelLen=0
2026/04/16 05:08:22 INFO [pg_query_executor] fetched rows x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id" rows=0 bytes=0 channelLen=0
2026/04/16 05:08:22 INFO [pg_query_executor] committing transaction x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart
2026/04/16 05:08:22 INFO [pg_query_executor] committed transaction for query x-peerdb-additional-metadata={Operation:FLOW_OPERATION_UNKNOWN} partitionId=testpart query="SELECT id,name,created_at FROM e2e_test_bq_8dhru5vc_20260416050738.\"test_partition_noroot\" ORDER BY id" rows=13 bytes=293 channelLen=0
--- FAIL: TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting (34.45s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@github-actions
Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: Three e2e tests deterministically fail because the generated PostgreSQL replication slot names exceed the 64-character limit (65–66 chars), which is a real bug in slot name generation for tests with long names.
Confidence: 0.95

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: BQ tests consistently fail because generated PostgreSQL replication slot names exceed the 64-character limit (caught by new validation in this PR), and TestCancelTableAdditionRemoveAddRemove fails because column c3 is missing from the destination after a cancel/re-add sequence — both are deterministic real failures, not timing-related flakiness.
Confidence: 0.82

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The e2e ClickHouse test failed with "SetupCDCFlowStatusQuery stuck in snapshot somehow" after 737 seconds, indicating a timing/race condition where the CDC flow failed to transition from snapshot to streaming mode — a known flaky pattern in Temporal-based integration tests.
Confidence: 0.88

✅ Automatically retrying the workflow

View workflow run

@github-actions
Copy link
Copy Markdown
Contributor

❌ Test Failure

Analysis: The test TestPeerFlowE2ETestSuiteBQ/Test_All_Types_Schema_Changes deterministically generates a PostgreSQL replication slot name of exactly 65 characters (one over the 64-char PostgreSQL limit) because the fixed components — peerflow_slot_ prefix (14), all_types_schema_changes table name (24), and the always-fixed-length _bq_XXXXXXXX_YYYYMMDDHHMMSS suffix (27) — sum to 65 regardless of the random 8-char component.
Confidence: 0.95

⚠️ This appears to be a real bug - manual intervention needed

View workflow run

Copy link
Copy Markdown
Contributor

@pfcoperez pfcoperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@github-actions
Copy link
Copy Markdown
Contributor

🔄 Flaky Test Detected

Analysis: The test TestGenericBQ/Test_Inheritance_Table_With_Dynamic_Setting failed with UNEXPECTED STATUS TIMEOUT STATUS_SNAPSHOT, a timing-dependent snapshot timeout consistent with resource contention in a high-concurrency CI environment — not a code regression.
Confidence: 0.88

✅ Automatically retrying the workflow

View workflow run

@ilidemi ilidemi merged commit 7ab1c2c into main Apr 16, 2026
16 of 17 checks passed
@ilidemi ilidemi deleted the fix-local-tests-some branch April 16, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants