Fix Snowflake resync failure due to case mismatch in _resync table suffix#4185
Open
kang8 wants to merge 1 commit intoPeerDB-io:mainfrom
Open
Fix Snowflake resync failure due to case mismatch in _resync table suffix#4185kang8 wants to merge 1 commit intoPeerDB-io:mainfrom
kang8 wants to merge 1 commit intoPeerDB-io:mainfrom
Conversation
…ffix (PeerDB-io#4184) The resync suffix was appended in lowercase ("_resync"), producing mixed-case identifiers like "ACCOUNTS_resync". However, getColsFromTable() in qrep.go unconditionally applies strings.ToUpper(), converting it to "ACCOUNTS_RESYNC". Since Snowflake treats quoted identifiers as case-sensitive, the table lookup fails with "does not exist". Uppercase the suffix to "_RESYNC" so both creation and query paths produce consistent identifiers.
kang8
requested a deployment
to
external-contributor
GitHub Actions
Waiting
kang8
requested a deployment
to
external-contributor
GitHub Actions
Waiting
kang8
requested a deployment
to
external-contributor
GitHub Actions
Waiting
kang8
requested a deployment
to
external-contributor
GitHub Actions
Waiting
kang8
requested a deployment
to
external-contributor
GitHub Actions
Waiting
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4184
_resyncsuffix was appended in lowercase, producing mixed-case identifiers likeACCOUNTS_resyncgetColsFromTable()inqrep.go:187unconditionally appliesstrings.ToUpper(), converting it toACCOUNTS_RESYNC_RESYNCto ensure consistent identifiers across creation and query pathsTest plan
_RESYNCsuffixgetColsFromTable()can find the resync tables_RESYNCafter resync completesgetColsFromTablewithToUpper)