Skip to content
This repository was archived by the owner on Apr 8, 2026. It is now read-only.

Add CockroachDB PeerType support#39

Open
viragtripathi wants to merge 1 commit intoPeerDB-io:mainfrom
viragtripathi:add-cockroachdb-peertype
Open

Add CockroachDB PeerType support#39
viragtripathi wants to merge 1 commit intoPeerDB-io:mainfrom
viragtripathi:add-cockroachdb-peertype

Conversation

@viragtripathi
Copy link
Copy Markdown

Added CockroachDB as a supported peer type following the same pattern as other database types (ClickHouse, Elasticsearch, etc.). This enables PeerDB integration with CockroachDB.

Changes

  • Added COCKROACHDB keyword to src/keywords.rs
  • Added CockroachDB variant to PeerType enum in src/ast/mod.rs
  • Updated Display impl for PeerType
  • Updated parse_peer_type function in src/parser/mod.rs

Testing

  • All existing tests pass
  • Code formatted with cargo fmt

Added CockroachDB as a supported peer type following the same pattern as other database types (ClickHouse, Elasticsearch, etc.). This enables PeerDB integration with CockroachDB.
@viragtripathi viragtripathi force-pushed the add-cockroachdb-peertype branch from 8b375d5 to 2531bc7 Compare January 21, 2026 07:23
@viragtripathi
Copy link
Copy Markdown
Author

Hi @Amogh-Bharadwaj Can you take a look at this PR and let me know if I am missing anything? This is to support PeerDB-io/peerdb#3861 PR. Thanks!

@serprex
Copy link
Copy Markdown
Member

serprex commented Apr 6, 2026

we will be archiving this repository, PeerDB-io/peerdb#4145
you can update your PR to peerdb accordingly after the above merges

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants