web: show guest-agent IP in VM Hardware box#401
Open
sacalito wants to merge 2 commits into
Open
Conversation
Review Summary by QodoDisplay guest-agent IP addresses in VM Hardware panel
WalkthroughsDescription• Adds IP address row to VM Hardware panel from QEMU guest agent • Displays guest agent reported IP addresses in monospace format • Only renders for running QEMU VMs with guest agent data • Matches existing CPU/Memory/Network row styling with Globe icon Diagramflowchart LR
A["VM Hardware Panel"] --> B["Check: isQemu && isRunning"]
B --> C["Check: guestInfo.ip_addresses exists"]
C --> D["Render IP Row"]
D --> E["Display with Globe icon & monospace font"]
File Changes1. web/src/vm_modals.js
|
Code Review by Qodo
1.
|
There was a problem hiding this comment.
Pull request overview
Mirrors QEMU guest-agent–reported IP addresses into the existing “VM Hardware” panel on the VM detail view, so IPs appear alongside CPU/Memory/Disk/Network for running QEMU VMs when available.
Changes:
- Adds a new “IP” row (Globe icon + monospace value) to the VM Hardware panel.
- Conditionally renders the row only for running QEMU VMs with
guestInfo.ip_addressespopulated.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
737ab0e to
9c5a89f
Compare
Add an IP row inside the VM Hardware panel that displays the addresses reported by the QEMU guest agent. Renders only for running QEMU VMs that have ip_addresses populated, matching the style of the existing CPU/Memory/Network rows.
Constrain the IP value span to flex-1 min-w-0 and allow break-all so multi-address (IPv4 + IPv6) results from the guest agent wrap instead of overflowing the Hardware panel. Switch the row to items-start with a small top offset on the icon so it aligns with the first line when the value wraps. Add a title tooltip with the full joined list.
9c5a89f to
55dccb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
guestInfo.ip_addresses).titletooltip showing the full joined list.The same data was already exposed in the separate Guest Agent Info card to the right; this PR mirrors it into the Hardware panel so it sits alongside the other per-VM resources.
Test plan
qemu-guest-agentinstalled — IP row appears under Network inside VM Hardware.isQemu).