Skip to content

Fix workflow client to extract packageIds from dataSources #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
darrell-d merged 1 commit into from
Mar 10, 2026
Merged

Fix workflow client to extract packageIds from dataSources #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion processor/clients/workflow_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,14 @@ def get_workflow_instance(self, workflow_instance_id):
response.raise_for_status()
data = response.json()

package_ids = []
for source in data.get("dataSources", {}).values():
package_ids.extend(source.get("packageIds", []))

workflow_instance = WorkflowInstance(
id=data["uuid"],
dataset_id=data["datasetId"],
package_ids=data["packageIds"],
package_ids=package_ids,
)

return workflow_instance
Expand Down
10 changes: 5 additions & 5 deletions tests/test_workflow_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def test_get_workflow_instance_success(self, mock_session_manager):
responses.add(
responses.GET,
"https://api.test.com/compute/workflows/runs/wf-instance-123",
json={"uuid": "wf-instance-123", "datasetId": "dataset-456", "packageIds": ["pkg-1", "pkg-2", "pkg-3"]},
json={"uuid": "wf-instance-123", "datasetId": "dataset-456", "dataSources": {"source-1": {"packageIds": ["pkg-1", "pkg-2", "pkg-3"]}}},
status=200,
)

Expand All @@ -68,7 +68,7 @@ def test_get_workflow_instance_includes_auth_header(self, mock_session_manager):
responses.add(
responses.GET,
"https://api.test.com/compute/workflows/runs/wf-123",
json={"uuid": "wf-123", "datasetId": "ds-1", "packageIds": []},
json={"uuid": "wf-123", "datasetId": "ds-1", "dataSources": {}},
status=200,
)

Expand Down Expand Up @@ -106,7 +106,7 @@ def test_get_workflow_instance_with_single_package(self, mock_session_manager):
responses.add(
responses.GET,
"https://api.test.com/compute/workflows/runs/wf-123",
json={"uuid": "wf-123", "datasetId": "ds-1", "packageIds": ["single-pkg"]},
json={"uuid": "wf-123", "datasetId": "ds-1", "dataSources": {"source-1": {"packageIds": ["single-pkg"]}}},
status=200,
)

Expand All @@ -131,7 +131,7 @@ def test_get_workflow_instance_retries_on_401(self, mock_session_manager):
responses.add(
responses.GET,
"https://api.test.com/compute/workflows/runs/wf-123",
json={"uuid": "wf-123", "datasetId": "ds-1", "packageIds": []},
json={"uuid": "wf-123", "datasetId": "ds-1", "dataSources": {}},
status=200,
)

Expand All @@ -152,7 +152,7 @@ def test_get_workflow_instance_retries_on_403(self, mock_session_manager):
responses.add(
responses.GET,
"https://api.test.com/compute/workflows/runs/wf-123",
json={"uuid": "wf-123", "datasetId": "ds-1", "packageIds": []},
json={"uuid": "wf-123", "datasetId": "ds-1", "dataSources": {}},
status=200,
)

Expand Down