Generic decomp rule lowering#3021
Draft
kipawaa wants to merge 98 commits into
Draft
Conversation
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
kipawaa
force-pushed
the
generic-decomp-rule-lowering
branch
from
July 17, 2026 16:14
51198cb to
9421d61
Compare
kipawaa
force-pushed
the
generic-decomp-rule-lowering
branch
from
July 17, 2026 17:38
9421d61 to
14cfd6d
Compare
paul0403
reviewed
Jul 21, 2026
| # TODO: not all PL ops have been migrated to the operator 2 format expected by mlir graph | ||
| # decomp This means some rules will fail the python callback compilation. When migration is | ||
| # complete, remove the try-except. | ||
| try: |
Member
There was a problem hiding this comment.
This inner try-except around the op id generation means we can remove the original try-except around the qjit right?
Contributor
Author
There was a problem hiding this comment.
It's more-so around the compute_resources, but yes! This way we can skip incompatible rules without skipping the op entirely
Contributor
|
Hello. You may have forgotten to update the changelog!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
Currently, multiple pathways exist for lowering a decomposition rule to MLIR. This increases maintenance burden and increases the surface for error and inconsistencies.
The current python-decomposition wrapper provides limited functionality, in particular it requires significant parsing after lowering to provide resources and target ID.
Description of the Change:
Improves the generic
python_decomposition_wrapperto support precompiled, trace-time and on-demand decomposition rule lowering.Benefits:
Consistent, unified decomposition rule lowering across all available timings and reduced maintenance burden.
Possible Drawbacks:
Related GitHub Issues:
[sc-122018]
[sc-122043]
[sc-122041]