Skip to content

Add support for graphOpId to the Graph Solver#3039

Merged
kipawaa merged 6 commits into
mainfrom
decomp/solver-id-support
Jul 20, 2026
Merged

Add support for graphOpId to the Graph Solver#3039
kipawaa merged 6 commits into
mainfrom
decomp/solver-id-support

Conversation

@kipawaa

@kipawaa kipawaa commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Context:
With the introduction of the DecomposableGate interface we have the opportunity to simplify the graph solver by operating on graphOpIds. This adds introductory support to the solver for ops with graphOpIds while continuing to support the legacy pathway.

Description of the Change:
Adds the id field to OperatorNode and updates comparison functions to use this, with the legacy pathway as a fallback for compatibility.

Benefits:
Steps towards a simplified graph solver and generic op support in the graph.

Possible Drawbacks:

Related GitHub Issues:

[sc-124975]

@kipawaa
kipawaa requested review from maliasadi and paul0403 July 17, 2026 15:32
Comment thread mlir/unittests/DecompGraphSolver/Test_DecompGraphCore.cpp

@paul0403 paul0403 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!

Comment thread mlir/unittests/DecompGraphSolver/Test_DecompGraphCore.cpp
Comment thread mlir/unittests/DecompGraphSolver/Test_DecompGraphCore.cpp
Comment thread mlir/unittests/DecompGraphSolver/Test_DecompGraphCore.cpp Outdated
Co-authored-by: Paul <79805239+paul0403@users.noreply.github.com>
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.96%. Comparing base (f76fb0e) to head (ff4a6b7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3039      +/-   ##
==========================================
- Coverage   96.98%   96.96%   -0.03%     
==========================================
  Files         165      165              
  Lines       19099    19099              
  Branches     1818     1818              
==========================================
- Hits        18523    18519       -4     
- Misses        421      424       +3     
- Partials      155      156       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kipawaa
kipawaa merged commit f0b6cae into main Jul 20, 2026
38 checks passed
@kipawaa
kipawaa deleted the decomp/solver-id-support branch July 20, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants