Update arguments for consistency

[jake73345634634]

Description

Updated the consistency of command-line arguments in the LDAP module for asreproasting and kerberoasting. The previous options were kept for compatibility, but new one added to asreproasting.

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Deprecation of feature or functionality
• This change requires a documentation update
• This requires a third party update (such as Impacket, Dploot, lsassy, etc)
• This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

No additional setup.

Screenshots (if appropriate):

No relevant screenshots.

Checklist:

Insert an "x" inside the brackets for completed and relevant items (do not delete options)

• I have ran Ruff against my changes (poetry: poetry run ruff check ., use --fix to automatically fix what it can)
• I have added or updated the tests/e2e_commands.txt file if necessary (new modules or features are required to be added to the e2e tests)
• If reliant on changes of third party dependencies, such as Impacket, dploot, lsassy, etc, I have linked the relevant PRs in those projects
• I have linked relevant sources that describes the added technique (blog posts, documentation, etc)
• I have performed a self-review of my own code (not an AI review)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (PR here: https://github.com/Pennyw0rth/NetExec-Wiki)

[NeffIsBack]

Hi and thanks for the PR!

I think we have discussed this once before and came to the conclusion that the shorter versions (--asreproast/--kerberoast) are more convenient, because less to type. However, I think as --kerberoast is autocompleted to --kerberoasting by argparse anyway, we never changed it.

[Marshall-Hallenbeck]

Hi and thanks for the PR!

I think we have discussed this once before and came to the conclusion that the shorter versions (--asreproast/--kerberoast) are more convenient, because less to type. However, I think as --kerberoast is autocompleted to --kerberoasting by argparse anyway, we never changed it.

even if it's autocompleted, that's not clear from the docs/code, so we could still add this without any regressions.

[NeffIsBack]

Hi and thanks for the PR!

I think we have discussed this once before and came to the conclusion that the shorter versions (--asreproast/--kerberoast) are more convenient, because less to type. However, I think as --kerberoast is autocompleted to --kerberoasting by argparse anyway, we never changed it.

even if it's autocompleted, that's not clear from the docs/code, so we could still add this without any regressions.

But it unnecessarily bloats the already overloaded help page.