Skip to content

Few minor fixes#1154

Merged
NeffIsBack merged 3 commits intomainfrom
neff-minor-fixes
Mar 14, 2026
Merged

Few minor fixes#1154
NeffIsBack merged 3 commits intomainfrom
neff-minor-fixes

Conversation

@NeffIsBack
Copy link
Member

Description

This PR:

  1. Changes the log message to .success because that is more appropriate when reporting on gathered creds.
  2. Fixes a stacktrace when prodcump fails to enumerate the pid (e.g. because AV blocked it)

Type of change

Insert an "x" inside the brackets for relevant items (do not delete options)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Deprecation of feature or functionality
  • This change requires a documentation update
  • This requires a third party update (such as Impacket, Dploot, lsassy, etc)
  • This PR was created with the assistance of AI (list what type of assistance, tool(s)/model(s) in the description)

Setup guide for the review

  1. run ... -M lsassy
  2. run ... -M procdump with windows defender running and blocking command execution

Screenshots (if appropriate):

  1. Before&After:
image

Before:
image

After:
image

Checklist:

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Mar 14, 2026
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeffIsBack NeffIsBack merged commit 2bd69e0 into main Mar 14, 2026
11 checks passed
@NeffIsBack NeffIsBack deleted the neff-minor-fixes branch March 14, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix This Pull Request fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants