Prevent doing database stuff if we don't have a valid connection#1155
Merged
NeffIsBack merged 1 commit intomainfrom Mar 14, 2026
Merged
Prevent doing database stuff if we don't have a valid connection#1155NeffIsBack merged 1 commit intomainfrom
NeffIsBack merged 1 commit intomainfrom
Conversation
mpgn
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With the changes introduced in #1133 we (rightfully) don't add users to the database if the auth is a guest or null auth. However, when relaying ntlmrelay marks this connection as guest auth while we still (potentially) are admin. This results in the step of "adding user to db" is skipped, but afterwards trying to add the admin relationship to a user that doesn't exist.
This PR solves this problem by deciding if the auth is legitimate (not guest/null auth for plaintext and not guest auth for hashes) and then doing all database/bloodhound stuff.
Type of change
Insert an "x" inside the brackets for relevant items (do not delete options)
Setup guide for the review
proxychains nxc smb -u user -p password -d domainScreenshots (if appropriate):
Before:

After:

Checklist: