fix(comments): render text + attachment together; show [[Name]] as 'via Altair · Name'#521
Open
KossaiSbai wants to merge 8 commits intoPeppermint-Lab:mainfrom
Open
fix(comments): render text + attachment together; show [[Name]] as 'via Altair · Name'#521KossaiSbai wants to merge 8 commits intoPeppermint-Lab:mainfrom
KossaiSbai wants to merge 8 commits intoPeppermint-Lab:mainfrom
Conversation
- Switch storage controller from fastify-multer to @fastify/multipart (fixes 415 Unsupported Media Type on file upload) - Add file serving endpoint GET /api/v1/storage/ticket/:id/file/:fileId - CommentContent component renders attachment links as clickable image previews and markdown bold text - GitHub Actions workflow builds and pushes to acraltairprod.azurecr.io
- Fire ALTAIR_COMMENT_WEBHOOK_URL on comment creation and status changes so BFF can email ticket submitters via Azure Communication Services - Add HMAC signature (ALTAIR_WEBHOOK_SECRET) on all outbound webhooks - Fix Peppermint UI scrollability (shad.tsx layout) - Add CI workflow: TypeScript build check on PRs and main - Update deploy workflow: SHA-pinned actions, split build/deploy jobs, update ACA Container App via az containerapp update after image push Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
apps/client has react-spinners@0.11.0 which requires react@^16/17 but the workspace uses react@18. The CI job runs from apps/api working-directory but npm resolves deps at the workspace root, hitting the conflict. --legacy-peer-deps bypasses the peer dep check without changing package behavior.
* feat: fix file upload, add image preview in comments, CI/CD to ACR - Switch storage controller from fastify-multer to @fastify/multipart (fixes 415 Unsupported Media Type on file upload) - Add file serving endpoint GET /api/v1/storage/ticket/:id/file/:fileId - CommentContent component renders attachment links as clickable image previews and markdown bold text - GitHub Actions workflow builds and pushes to acraltairprod.azurecr.io * feat: Altair customizations — webhooks, scrollability, CI/CD - Fire ALTAIR_COMMENT_WEBHOOK_URL on comment creation and status changes so BFF can email ticket submitters via Azure Communication Services - Add HMAC signature (ALTAIR_WEBHOOK_SECRET) on all outbound webhooks - Fix Peppermint UI scrollability (shad.tsx layout) - Add CI workflow: TypeScript build check on PRs and main - Update deploy workflow: SHA-pinned actions, split build/deploy jobs, update ACA Container App via az containerapp update after image push Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(ci): add --legacy-peer-deps to npm install apps/client has react-spinners@0.11.0 which requires react@^16/17 but the workspace uses react@18. The CI job runs from apps/api working-directory but npm resolves deps at the workspace root, hitting the conflict. --legacy-peer-deps bypasses the peer dep check without changing package behavior. --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
…ion prefix - CommentContent now extracts text before the attachment line and renders it above the image/link - Strip [[Name]]\n prefix from comment text before rendering so admins don't see raw attribution tags Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…me]] as 'via Altair · Name' - CommentContent now extracts [[Name]]\n prefix and renders it as a small 'via Altair · Name' label so admins can see which Altair user posted - Text before the attachment line is rendered above the image (was dropped before) - Attribution label applies to all comment types: plain, bold, debug context, attachment Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@KossaiSbai is attempting to deploy a commit to the peppermint labs Team on Vercel. A member of the Team first needs to authorize it. |
… wiped in merge conflict) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommentContentextracts the[[Name]]\nprefix and renders it asvia Altair · Jane Admin— admins still see who postedBefore / After
Before:
[[Jane Admin]]\nfejofjqefqfjepjef\n\n📎 Attachment: [img.png](url)→ only the image, no text, raw[[Jane Admin]]shown in other comments.After:
via Altair · Jane Adminlabel → text → image thumbnail, for all comment types.Test plan
[[Name]]prefix render unchanged🤖 Generated with Claude Code