fix(sourceWorker): inherit execArgv so tsx loader reaches micro-workers#201
fix(sourceWorker): inherit execArgv so tsx loader reaches micro-workers#201dripink wants to merge 2 commits intoPerformanC:devfrom
Conversation
sync: v3 < dev
|
All Contributors have signed the CLA. The PR is now allowed to be merged. |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
|
@doyimmiuink please use a email linked to your GitHub account. |
|
I will create another PR with the correct credentials; you can discard this one. |
Worker threads spawned via new Worker(__filename) do not inherit process.execArgv, causing them to crash when the parent was started with --import tsx. Passing execArgv: process.execArgv fixes the crash-respawn loop seen with the default npm start script.
221778f to
47c9491
Compare
|
recheck |
|
updated with the correct email linked to my GitHub account. Ready for review |
|
Great, thanks. We'll merge it soon. |
|
@doyimmiuink the issue is still present for me on NodeJS version
|
|
It's a nodejs problem, as it's working fine on |
|
I'll review this here, as some that I tested worked, but some didn't. |
|
Fix not working on my end. The only workaround I found for the build is adding extra heap space so it doesn't run out of memory: |
|
This request will be denied because it is incomplete, and the solution will be implemented in the dev branch. |

Changes
Passing execArgv: process.execArgv fixes the crash-respawn loop seen with the default npm start script.
Why
Worker threads spawned via new Worker(__filename) do not inherit process.execArgv, which causes them to crash when the parent was started with --import tsx.
Checkmarks
Additional information
If you have any additional information, write it here