Generate proto.h entries for those marked 'X'#24543
Merged
Merged
Conversation
demerphq
reviewed
Jul 7, 2026
Contributor
|
Can this be exercised by the test suite? |
This fixes Perl#24541. The embed.fnc 'X' flag means that the Perl_ form of a function is supposed to be visible everywhere, with the short name hidden outside the core (or extensions, if the 'E' flag is also given). The wording of the comments in embed.fnc was confusing about this. This commit revises that, and makes formerly invisible functions now have prototypes generated for them, which makes them visible. It also changes some tabs to spaces in embed.fnc. This file is supposed to have both, depending on context, so automatic fixing isn't enabled, and a few lines had gotten off.
Contributor
Author
|
I compared the newly visible symbols against 5.42. All the ones that existed in 5.42 were visible then, so this restores all those to the previous release's state. There is one new symbol; compilation failed when I tried to change it to be hidden now. |
Leont
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #24541.
The embed.fnc 'X' flag means that the Perl_ form of a function is supposed to be visible everywhere, with the short name hidden outside the core (or extensions, if the 'E' flag is also given).
The wording of the comments in embed.fnc was confusing about this. This commit revises that, and makes formerly invisible functions now have prototypes generated for them, which makes them visible.