regen/regcomp.pl - totally new regcomp.sym structure using data driven conf#24546
Open
demerphq wants to merge 1 commit into
Open
regen/regcomp.pl - totally new regcomp.sym structure using data driven conf#24546demerphq wants to merge 1 commit into
demerphq wants to merge 1 commit into
Conversation
…n conf no more cryptic config file to read. no more confusion. For years now we have used this cryptic config file to define the regex engine opcode structure. The format of the data it contains is pretty cryptic, and it always feels like something might go boom if you change it. This patch changes it to be a Perl data structure which is read and can be written by regcomp.pl. If we want to refactor the config format it should now be much easier to do so. I tried to structure things so it wouldn't feel too different from the old format, but also be much more clear what is right and wrong, and etc. The patch includes pod and documentation so i wont duplicate that in this message.
demerphq
force-pushed
the
yves/refactor_regcomp_sym
branch
from
407c8d6 to
f7c35e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no more cryptic config file to read. no more confusion.
For years now we have used this cryptic config file to define the regex engine opcode structure. The format of the data it contains is pretty cryptic, and it always feels like something might go boom if you change it.
This patch changes it to be a Perl data structure which is read and can be written by regcomp.pl. If we want to refactor the config format it should now be much easier to do so.
I tried to structure things so it wouldn't feel too different from the old format, but also be much more clear what is right and wrong, and etc. The patch includes pod and documentation so i wont duplicate that in this message.