fix: make claimVouchedHat idempotent for batch compatibility#116
Open
fix: make claimVouchedHat idempotent for batch compatibility#116
Conversation
When registerAndQuickJoinWithPasskey and claimVouchedHat target the same hat in an executeBatch, the first call mints it and the second should be a no-op instead of reverting. Changed claimVouchedHat to return early if the user already wears the hat. Added two integration tests to verify the fix works end-to-end. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Contributor
Coverage Report
Coverage by file
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed batch UserOp compatibility issue where
registerAndQuickJoinWithPasskey+claimVouchedHatfor the same hat would revert on the second call.Changed behavior:
claimVouchedHatnow returns early (no-op) if the user already wears the hat instead of reverting with "Already wearing hat".Tests: Added two integration tests that verify the fix works end-to-end:
testClaimVouchedHat_IdempotentandtestQuickJoinThenClaimVouchedHat_NoConflict.🤖 Generated with Claude Code