Fix build-blockers + add wrapper/icon/tests/CI (blocked on FFmpegKit dep)#1
Draft
Peterc3-dev wants to merge 1 commit into
Draft
Fix build-blockers + add wrapper/icon/tests/CI (blocked on FFmpegKit dep)#1Peterc3-dev wants to merge 1 commit into
Peterc3-dev wants to merge 1 commit into
Conversation
The repo did not build at all. This fixes the mechanical blockers and adds test/CI scaffolding. NOTE: it still won't fully compile until the FFmpegKit dependency is resolved (see PR body) — kept as a draft for that reason. - Add the missing Gradle wrapper (gradlew, gradlew.bat, gradle-wrapper.jar @ 8.9) - Fix settings.gradle.kts: `dependencyResolution` -> `dependencyResolutionManagement` (invalid block name; google()/mavenCentral() were unresolved) - Add an adaptive launcher icon (@mipmap/ic_launcher was referenced but missing), built from the existing music-note vector; minSdk 26 so anydpi-v26 suffices - Drop the invalid `?attr/colorControlNormal` tint on ic_music_note (Compose-only app, AppCompat attr unavailable) - Add JUnit unit tests for AudioConverter pure logic (extension parsing, supported formats, 432/440 ratio) + a build/test/lint CI workflow Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo was completely unbuildable. This PR fixes four real build-blockers and adds test + CI scaffolding:
gradle-wrapper.propertieswas committed; addedgradlew,gradlew.bat,gradle-wrapper.jar(Gradle 8.9).settings.gradle.kts— useddependencyResolution { }(not a real block) instead ofdependencyResolutionManagement { }, sogoogle()/mavenCentral()were unresolved.@mipmap/ic_launcherwas referenced in the manifest but no icon existed; added an adaptive icon built from the existing music-note vector (minSdk 26 →mipmap-anydpi-v26suffices).ic_music_noteused?attr/colorControlNormal(AppCompat) in a Compose-only app.Also adds JUnit tests for
AudioConverterpure logic + a build/test/lint CI workflow.AudioConverterimportscom.arthenica.ffmpegkit.{FFmpegKit,FFmpegKitConfig,FFprobeKit,ReturnCode}but noffmpeg-kitdependency is declared and no binary is bundled (the// ffmpeg binary bundled in assets/comment is inaccurate — there is noassets/). The upstreamcom.arthenica:ffmpeg-kitlibrary was discontinued in 2025 and its artifacts removed, so the app cannot compile until a replacement is wired in.Decision needed (yours): pick one —
Once the audio dependency resolves, the added unit tests + CI should pass as-is. Local verification got resources linking + the build progressing through all four fixes above before hitting the FFmpegKit import wall.
🤖 Generated with Claude Code