Add Zygor Guides item score integration#176
Open
dlamanna wants to merge 2 commits intoPeterodox:mainfrom
Open
Conversation
Adds a SupportedAddOn integration for ZygorGuidesViewer that overrides DialogueUI's upgrade detection and tooltip display with Zygor's stat-weight-based item scoring system. - Override IsItemAnUpgrade_External to use Zygor's Upgrades:IsUpgrade() for more accurate upgrade arrows on quest reward items - Override ProcessItemExternal on SharedTooltip to show Zygor ItemScore upgrade/downgrade percentages per equipment slot - Handle deferred item data by signaling "not ready" so DialogueUI retries - Follow the same AddSupportedAddOn pattern used by Pawn integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Zygor does not score trinkets, so they previously showed no upgrade arrow and a gray "not part of scoring system" tooltip message. Now when Zygor returns "not scored" for a trinket, we fall back to item-level comparison against both equipped trinket slots. - Upgrade arrow: delegates to built-in API.IsItemAnUpgrade for trinkets - Tooltip: shows per-slot ilvl deltas (Trinket 1/2) with color-coded upgrade/downgrade/no-change lines and empty-slot handling - Fails soft if ilvl data isn't available yet Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupportedAddOns/Zygor.luaintegration following the existing Pawn.lua patternAPI.IsItemAnUpgrade_Externalto use Zygor's stat-weight scoring instead of simple ilvl comparisonSharedTooltip:ProcessItemExternalto display Zygor ItemScore upgrade/downgrade percentages in DialogueUI's custom tooltipDetails
When Zygor Guides is installed and has an active rule set, quest reward items in DialogueUI will show:
Falls back to the built-in
API.IsItemAnUpgradewhen Zygor has no active rule set.Files Changed
Code/SupportedAddOns/Zygor.lua— new fileCode/SupportedAddOns/SupportedAddOns.xml— added<Script file="Zygor.lua"/>Test Plan
🤖 Generated with Claude Code