Enhanced QuickSlot: always-on loot popup with queue#177
Open
dlamanna wants to merge 5 commits intoPeterodox:mainfrom
Open
Enhanced QuickSlot: always-on loot popup with queue#177dlamanna wants to merge 5 commits intoPeterodox:mainfrom
dlamanna wants to merge 5 commits intoPeterodox:mainfrom
Conversation
5ae47e0 to
5188011
Compare
Check item count before calling SetUsableItem() in UpdateItem(). When the count reaches 0 (container opened/consumed), skip re-registration of bag events and timers, disable the button, and trigger OnItemConsumed() to start a short dismiss countdown. This prevents the popup from staying on screen indefinitely after opening bags/chests. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the QuickSlot system to listen for loot from all earned sources (not just quest completion), queue multiple popup candidates, and handle deferred item evaluation gracefully.
CHAT_MSG_LOOTpermanently to catch boss drops, world drops, treasure chests, bonus rolls, etc.Architecture
Four logical units, all in
Widget_QuickSlot.lua:OnItemLootedroutes through filter → queue/deferred, with BAG_UPDATE_DELAYED fallbackFiles Changed
Code/Widget/Widget_QuickSlot.lua— all four units + popup dismiss/equip/use wiringCode/Settings/Settings.lua— two new checkbox entriesInitialization.lua— default values forQuickSlotAlwaysOnandQuickSlotPriorityOnlyLocales/enUS.lua— setting labels and descriptionsdocs/plans/— design doc and implementation plan (can be excluded from merge if preferred)Non-Goals
Test Plan
🤖 Generated with Claude Code