Prototype for creating one timer coro per output thread#29
Open
PettitWesley wants to merge 12 commits intos3-refactor-timer-coros-awspr-sched-expfrom
Open
Prototype for creating one timer coro per output thread#29PettitWesley wants to merge 12 commits intos3-refactor-timer-coros-awspr-sched-expfrom
PettitWesley wants to merge 12 commits intos3-refactor-timer-coros-awspr-sched-expfrom
Conversation
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
matthewfala
reviewed
Oct 23, 2023
plugins/out_s3/s3.c
Outdated
Comment on lines
+2013
to
+2014
| if (current_th_ins == NULL) { | ||
| //TODO: ? |
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.