Pause input ingestion halfway through Grace period#33
Open
PettitWesley wants to merge 3 commits into2_33_awsbasefrom
Open
Pause input ingestion halfway through Grace period#33PettitWesley wants to merge 3 commits into2_33_awsbasefrom
PettitWesley wants to merge 3 commits into2_33_awsbasefrom
Conversation
PettitWesley
force-pushed
the
grace-input-aws
branch
from
9245d0d to
85b13c0
Compare
PettitWesley
force-pushed
the
grace-input-aws
branch
from
9b813f6 to
b299475
Compare
PettitWesley
force-pushed
the
grace-input-aws
branch
from
b299475 to
b8954cf
Compare
PettitWesley
force-pushed
the
grace-input-aws
branch
from
b8954cf to
8c46a8a
Compare
PettitWesley
force-pushed
the
grace-input-aws
branch
from
8c46a8a to
67b1582
Compare
1. Input grace period Currently, Fluent Bit pauses all inputs 1 second after SIGTERM. The change creates an input grace period, which by default is one half the total Grace setting. This means that half way through the grace period Fluent Bit stops accepting any new logs and only sends logs pending in the buffers. 2. Check pending chunks on shutdown Previously the engine shutdown immediately if there were no pending tasks. A task is created from a chunk in the buffer. If there is a new chunk, but no task yet, the engine should keep running until the task is created and completed. This change makes the engine wait on shutdown for all pending chunks until the max grace period has expired.
PettitWesley
force-pushed
the
grace-input-aws
branch
from
67b1582 to
362aa77
Compare
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
PettitWesley
force-pushed
the
grace-input-aws
branch
from
ed938c2 to
79445f7
Compare
Signed-off-by: Wesley Pettit <wppttt@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.