fix procedure for adding level match metadata to FITS#145
Open
rchwn wants to merge 1 commit intoPhangsTeam:mainfrom
Open
fix procedure for adding level match metadata to FITS#145rchwn wants to merge 1 commit intoPhangsTeam:mainfrom
rchwn wants to merge 1 commit intoPhangsTeam:mainfrom
Conversation
Collaborator
|
This looks like it should be fine to me (though I haven't tested), but it would be nice to also inject into the ASDF metadata like we do with the astrometric alignment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue resulting from #125 where coefficients from the
level_match_stepwere not being added properly to the saved FITS files. The code from that PR worked but with deprecated stdatamodel infrastructure (im.extra_fits.PRIMARY). Spot tested the current fix and it works for me, but would be good if someone else could confirm (perhaps @akleroy or @thomaswilliamsastro ).