fix: correct _is_phased() early return and prevent KeyError on duplicate variants#227
Open
haoyu-haoyu wants to merge 1 commit intoPharmGKB:mainfrom
Open
fix: correct _is_phased() early return and prevent KeyError on duplicate variants#227haoyu-haoyu wants to merge 1 commit intoPharmGKB:mainfrom
haoyu-haoyu wants to merge 1 commit intoPharmGKB:mainfrom
Conversation
…ate variants 1. _is_phased(): The function returned on the first sample without checking all samples. Now iterates through all GT fields — returns False if ANY sample is unphased, True only if ALL are phased. 2. extract_pgx_variants(): .pop() calls on ref_pos_dynamic can raise KeyError when multiple input variants normalize to the same coordinate. Changed to .pop(key, None) to handle collisions gracefully. Fixes PharmGKB#222
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two bugs fixed in
preprocessor/pcat/utilities.py:1.
_is_phased()returns on first sample (line ~879)The function checks phasing status but returns immediately on the first GT field, never examining subsequent samples.
Impact: Multi-sample VCFs may have incorrect phasing determination, leading to wrong star allele calls.
2. KeyError on duplicate normalized variants (fixes #222)
ref_pos_dynamic[pos].pop(ref_alt)crashes when multiple input variants normalize to the same coordinate/allele pair. Changed to.pop(key, None)to handle collisions gracefully.Test plan
cd preprocessor && pytest tests/