Skip to content

feat: add folders in browser#50

Merged
Julesboul merged 5 commits intoPharo-XP-Tools:P14from
nicolasp025:feat/record-folders
Apr 21, 2026
Merged

feat: add folders in browser#50
Julesboul merged 5 commits intoPharo-XP-Tools:P14from
nicolasp025:feat/record-folders

Conversation

@nicolasp025
Copy link
Copy Markdown

No description provided.

@nicolasp025 nicolasp025 marked this pull request as ready for review April 21, 2026 09:26
@nicolasp025 nicolasp025 requested a review from Julesboul April 21, 2026 09:26
Comment thread DebuggingSpy-Browser/DSRecordBrowserPresenter.class.st
Comment thread DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
Comment thread DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st Outdated
Comment thread DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
Comment thread DebuggingSpy-Browser/DSRecordBrowserPresenter.class.st Outdated
Comment thread DebuggingSpy-Browser-Tests/DSRecordBrowserPresenterTest.class.st
@nicolasp025 nicolasp025 requested a review from Julesboul April 21, 2026 14:02
Copy link
Copy Markdown
Contributor

@Julesboul Julesboul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just add an unit-test DSRecordBrowserPresenterTest >> testIsFileAdded and change the name of the existing one (which is a functional test).

It is better to have both because functionnal tests can failed due to other methods than the one tested

@Julesboul Julesboul merged commit 4c15874 into Pharo-XP-Tools:P14 Apr 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants