Initial Merge Pull Request#2
Initial Merge Pull Request#2MishaSavchenko wants to merge 33 commits intoPhys767-Spring17:masterfrom
Conversation
drewjrosen
left a comment
drewjrosen
left a comment
There was a problem hiding this comment.
Basically you need to comment more on everything.
Log_of_planck_function.py
Outdated
| # So logflux (which is what we want) is just the log of this | ||
| logflux[i] = logfactor + np.log10(flux[i]) | ||
| return logflux | ||
|
|
There was a problem hiding this comment.
You should comment on everything below. Explain more what is going on.
Spectral_Radiance.py
Outdated
| @@ -0,0 +1,54 @@ | |||
| from __future__ import print_function | |||
…ion from the MCMC calculation
…ons with an arbitrary and a calculated burn point
…esult int results.dat, Spectral_radiance uses results.dat to plot last estimate, spectral_radiance.py does the same with some issues
kelle
left a comment
kelle
left a comment
There was a problem hiding this comment.
I made several comments in line.
also, files in pycache should not be here. Several other students have had all these extra files in their repos as well. Consider asking David for help.
.cache/v/cache/lastfailed
Outdated
| @@ -0,0 +1 @@ | |||
| {} No newline at end of file | |||
There was a problem hiding this comment.
this file should not be tracked by github. (Nothing in the .cache directory should be.)
| @@ -0,0 +1,474 @@ | |||
| { | |||
There was a problem hiding this comment.
Pretty sure this file shouldn't be tracked either.
mcmc_test/Log_of_planck_function.py
Outdated
| flux=np.empty([len(wavelength)]) | ||
| logflux=np.empty([len(wavelength)]) | ||
| for i in range(len(wavelength)): | ||
| # Flux is just the Planck function |
mcmc_test/Log_of_planck_function.py
Outdated
| for i in range(len(wavelength)): | ||
| # Flux is just the Planck function | ||
| flux[i] = ( (2.0*con.h*con.c**2)/(wavelength[i]**5) )/( np.exp( (con.h*con.c)/(con.k*Teff*wavelength[i]) ) - 1.0 ) | ||
| # So logflux (which is what we want) is just the log of this |
There was a problem hiding this comment.
delete "just". logflux is the log of the Planck function.
mcmc_test/Log_of_planck_function.py
Outdated
|
|
||
| results = ascii.read("results.dat") | ||
|
|
||
| T1 = 100 |
mcmc_test/Log_of_planck_function.py
Outdated
| T3 = 300 | ||
| MCMC_Temp = results[0][0] | ||
|
|
||
| Y1_B = (np.log10(planck(X*10**-6,T1))) |
There was a problem hiding this comment.
I dont know what the code is doing here. what does Y1_B mean?
mcmc_test/Log_of_planck_function.py
Outdated
| Y4_B = (np.log10(planck(X*10**-6,T3))) | ||
|
|
||
|
|
||
| x = np.asarray([3.368,4.618,12.082,22.194,3.6,4.5]) |
There was a problem hiding this comment.
where do these numbers come from?
3 participants
No description provided.