fix: security hardening and code quality improvements#29
Open
benzntech wants to merge 8 commits intoPickle-Pixel:mainfrom
Open
fix: security hardening and code quality improvements#29benzntech wants to merge 8 commits intoPickle-Pixel:mainfrom
benzntech wants to merge 8 commits intoPickle-Pixel:mainfrom
Conversation
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses 20+ findings from a comprehensive code review across 16 files.
🔴 Critical Fixes
?placeholders indetail.py,launcher.py,scorer.py$APPLYPILOT_SITE_PASSWORDenv var; CapSolver API calls moved frombrowser_evaluate(page context) toBash curlto prevent key exfiltrationescape(location.lower())added to dashboard HTML attributesbypassPermissions🟠 High Priority Fixes
threading.Lockwith double-check locking;atexit.registercloseshttpx.Clientbrowser.close()protected by try/except aroundpage.goto()in smartextractbatch_convert()reuses single Chromium instance instead of launching one per filestore_jobsacquire_jobretries onsqlite3.OperationalErrorwith backofferrorstatus when all passes failed🟡 Medium/Low Fixes
dict[str, Callable]with propercollections.abcimport in pipeline.pyyaml.safe_load(...) or {}on all code paths in config.pyLIMIT 500to prevent OOM on large databasesclose_all_connections()helper for thread cleanup!= "nan"string comparisons with_clean()helper in jobspy.py$,,, whitespace before splitting ranges in wizardAll 27 Python files compile cleanly after changes.