Handle WASMagic import errors

[signadou]

Closes #600

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of file type detection with enhanced error handling and graceful fallback mechanisms.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7570b204-492a-40f4-956c-3f6b7edf11d9

📥 Commits

Reviewing files that changed from the base of the PR and between 299edfc and 0210f8e.

📒 Files selected for processing (1)

• src/installationDetection.ts

---

📝 Walkthrough

Walkthrough

The PR replaces direct WASMagic usage with a lightweight MagicDetector interface abstraction in installationDetection.ts. Dynamic import wrapping with try/catch error handling is introduced to gracefully handle WASMagic loading failures, with the getMagicInstance function return type updated from Promise<WASMagic | null> to Promise<MagicDetector | null>.

Changes

Cohort / File(s)	Summary
WASMagic abstraction and error handling src/installationDetection.ts	Introduces MagicDetector interface, updates getMagicInstance() return type and magicInstancePromise variable type, wraps dynamic import in async IIFE with try/catch for graceful failure handling when WASMagic is unavailable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Add a fallback for WASMagic when it's not available #399: Decouples direct WASMagic usage in installationDetection.ts with abstraction and nullable detector pattern to handle WASMagic loading failures.

Suggested reviewers

• bl-ue

Poem

🐰 A lighter touch for magic spells,
When SIMD fails on distant fells,
We catch and gracefully defer,
No crashes now—just silent purr! ✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically describes the main change: handling WASMagic import errors, which directly addresses the primary objective of preventing crashes from WASM initialization failures.
Linked Issues check	✅ Passed	The code changes implement error handling for WASMagic import/initialization failures through a try/catch wrapper and graceful fallback to null, directly addressing issue #600's requirement to prevent crashes on RHEL 8 due to WASM SIMD incompatibility.
Out of Scope Changes check	✅ Passed	All changes are directly related to handling WASMagic import errors: introducing the MagicDetector interface, updating function signatures, and wrapping dynamic imports with error handling. No extraneous modifications detected.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch handle-wasmagic-import-errors-031026

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}