fix: bypass keybinding customization gate for nonessential traffic mode#658
fix: bypass keybinding customization gate for nonessential traffic mode#658VitalyOstanin wants to merge 1 commit intoPiebald-AI:mainfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughA new patch, Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Custom keybindings from ~/.claude/keybindings.json are blocked when CLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1 because the feature flag tengu_keybinding_customization_release defaults to false without GrowthBook. This patch force-enables the gate function.
71d87e8 to
5ff401d
Compare
Summary
Custom keybindings from
~/.claude/keybindings.jsonare silently ignored whenCLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1. Thetengu_keybinding_customization_releasefeature flag defaults tofalsewithout GrowthBook, causingisKeybindingCustomizationEnabled()to block all user keybinding loading.This patch force-enables the gate function (
return !0;before the GrowthBook check), same technique as worktreeMode, voiceMode, and channelsMode patches.Changes
keybindingCustomization.ts— patch implementation with idempotency checkkeybindingCustomization.test.ts— tests for success, already-patched, and pattern-not-foundindex.ts— register patch asALWAYS_APPLIED(no config condition)Test plan
pnpm test— 224 tests passpnpm lint— no errorsCLAUDE_CODE_DISABLE_NONESSENTIAL_TRAFFIC=1Summary by CodeRabbit
New Features
Tests