Open
Conversation
Collaborator
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
So, we'll have to have the nullable preview to build locally?
Owner
Author
|
I wasn’t really planning on merging, I just wanted to see what it would take, and what the changes looked like. |
jaredpar
reviewed
May 7, 2018
| // Can't figure out how to not get a warning here. | ||
| #pragma warning disable CS8603 | ||
| return this[index]; | ||
| #pragma warning restore |
Collaborator
There was a problem hiding this comment.
Could add a ?? throw here to remove the exception. That will function. Don't think that can be a shipping solution though.
Owner
Author
There was a problem hiding this comment.
I tried that, and the warning didn't go away - maybe a bug in the preview.
jaredpar
reviewed
May 7, 2018
| public static Window Instance { get; private set; } | ||
|
|
||
| // WPF generates fields that are marked as non-nullable, but not definitely initialized. | ||
| #pragma warning disable CS8618 |
Collaborator
There was a problem hiding this comment.
That's going to be a problem if we have to do this for every single WPF control.
Owner
Author
There was a problem hiding this comment.
Indeed - see my mails to the LDM on the topic :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotate for the Nullable reference types preview.