Fix bug where AddNewLayer() emitted a LayerAdded event with the wrong index#2150
Merged
Conversation
… index. The event was always fired with the index of the topmost layer, which is wrong if a different layer is selected. Also refactored a bit so that this method updates the selected layer and emits an event for the selection change , to be consistent with DuplicateLayer() Since the layers list view uses this index to create list items which hold a reference to the UserLayer, the new item in the list would be referencing the wrong layer. In the bug report, this was why the third layer showed up with the name "Layer 2" rather than "Layer 3", and eventually led to the crash after layer 2 was removed. Fixes: #2129
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The event was always fired with the index of the topmost layer, which is wrong if a different layer is selected. Also refactored a bit so that this method updates the selected layer and emits an event for the selection change , to be consistent with DuplicateLayer()
Since the layers list view uses this index to create list items which hold a reference to the UserLayer, the new item in the list would be referencing the wrong layer. In the bug report, this was why the third layer showed up with the name "Layer 2" rather than "Layer 3", and eventually led to the crash after layer 2 was removed.
Fixes: #2129